diff --git a/src/vs/platform/actions/common/actions.ts b/src/vs/platform/actions/common/actions.ts index 201198887a07d0b89a2e422d63fc4a943dc8737a..dcf943843d6739e4ccbae837a2ba5712275f519d 100644 --- a/src/vs/platform/actions/common/actions.ts +++ b/src/vs/platform/actions/common/actions.ts @@ -58,6 +58,8 @@ export function isISubmenuItem(item: IMenuItem | ISubmenuItem): item is ISubmenu export class MenuId { + private static _idPool = 0; + static readonly CommandPalette = new MenuId('CommandPalette'); static readonly DebugBreakpointsContext = new MenuId('DebugBreakpointsContext'); static readonly DebugCallStackContext = new MenuId('DebugCallStackContext'); @@ -113,7 +115,6 @@ export class MenuId { static readonly BulkEditTitle = new MenuId('BulkEditTitle'); static readonly BulkEditContext = new MenuId('BulkEditContext'); - private static _idPool = 0; readonly id: number; readonly _debugName: string; diff --git a/src/vs/workbench/api/common/menusExtensionPoint.ts b/src/vs/workbench/api/common/menusExtensionPoint.ts index 0e441ee01d566a683a18b6c2a7105b2d2a9c32f5..c79a3c16ab05f195ffb28928f71915b37567c47a 100644 --- a/src/vs/workbench/api/common/menusExtensionPoint.ts +++ b/src/vs/workbench/api/common/menusExtensionPoint.ts @@ -414,7 +414,7 @@ ExtensionsRegistry.registerExtensionPoint<{ [loc: string]: schema.IUserFriendlyM } const menu = schema.parseMenuId(entry.key); - if (typeof menu !== 'number') { + if (typeof menu === 'undefined') { collector.warn(localize('menuId.invalid', "`{0}` is not a valid menu identifier", entry.key)); return; }