From d88ac6f164eb2f42a02a86e00f81808e24317b3c Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Thu, 5 Nov 2020 12:10:32 -0800 Subject: [PATCH] Finalize the isWritableFileSystem API Fixes #91697 --- src/vs/vscode.d.ts | 15 +++++++++++++++ src/vs/vscode.proposed.d.ts | 22 ---------------------- 2 files changed, 15 insertions(+), 22 deletions(-) diff --git a/src/vs/vscode.d.ts b/src/vs/vscode.d.ts index 99ba257dbf7..eb7426c56be 100644 --- a/src/vs/vscode.d.ts +++ b/src/vs/vscode.d.ts @@ -6860,6 +6860,21 @@ declare module 'vscode' { * @param options Defines if existing files should be overwritten. */ copy(source: Uri, target: Uri, options?: { overwrite?: boolean }): Thenable; + + /** + * Check if a given file system supports writing files. + * + * Keep in mind that just because a file system supports writing, that does + * not mean that writes will always succeed. There may be permissions issues + * or other errors that prevent writing a file. + * + * @param scheme The scheme of the filesystem, for example `file` or `git`. + * + * @return `true` if the file system supports writing, `false` if it does not + * support writing (i.e. it is readonly), and `undefined` if VS Code does not + * know about the filesystem. + */ + isWritableFileSystem(scheme: string): boolean | undefined; } /** diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index 7516d721fb7..e237a0c4368 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -2141,28 +2141,6 @@ declare module 'vscode' { } //#endregion - //#region https://github.com/microsoft/vscode/issues/91697 - - export interface FileSystem { - /** - * Check if a given file system supports writing files. - * - * Keep in mind that just because a file system supports writing, that does - * not mean that writes will always succeed. There may be permissions issues - * or other errors that prevent writing a file. - * - * @param scheme The scheme of the filesystem, for example `file` or `git`. - * - * @return `true` if the file system supports writing, `false` if it does not - * support writing (i.e. it is readonly), and `undefined` if VS Code does not - * know about the filesystem. - */ - isWritableFileSystem(scheme: string): boolean | undefined; - } - - - //#endregion - //#region https://github.com/microsoft/vscode/issues/108929 FoldingRangeProvider.onDidChangeFoldingRanges @aeschli export interface FoldingRangeProvider2 extends FoldingRangeProvider { -- GitLab