From d638b29ab8984dff26da161d0e300b4ed9dd92d0 Mon Sep 17 00:00:00 2001 From: Peng Lyu Date: Tue, 10 Apr 2018 11:02:49 -0700 Subject: [PATCH] No review overlay when there is no comment. --- src/vs/editor/contrib/review/review.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/vs/editor/contrib/review/review.ts b/src/vs/editor/contrib/review/review.ts index 600316fe377..04c3cb4ebdd 100644 --- a/src/vs/editor/contrib/review/review.ts +++ b/src/vs/editor/contrib/review/review.ts @@ -501,6 +501,10 @@ export class ReviewController implements IEditorContribution { setComments(commentThreads: modes.CommentThread[]): void { this._commentThreads = commentThreads; + if (this._commentThreads.length === 0) { + return; + } + if (!this._reviewSwitch) { this._reviewSwitch = new ReviewSwitchWidget(this._reviewModel); this.editor.addOverlayWidget(this._reviewSwitch); -- GitLab