From d5fa376c28d29b53d596cf22dcd42cc02666ced5 Mon Sep 17 00:00:00 2001 From: Dirk Baeumer Date: Wed, 29 Mar 2017 16:36:22 +0200 Subject: [PATCH] Fixes #23577: Send run task activation even whnen task open handler is used. --- .../workbench/parts/tasks/browser/taskQuickOpen.ts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/parts/tasks/browser/taskQuickOpen.ts b/src/vs/workbench/parts/tasks/browser/taskQuickOpen.ts index 80d951b898d..b7f8e4515e2 100644 --- a/src/vs/workbench/parts/tasks/browser/taskQuickOpen.ts +++ b/src/vs/workbench/parts/tasks/browser/taskQuickOpen.ts @@ -12,6 +12,8 @@ import { IQuickOpenService } from 'vs/platform/quickOpen/common/quickOpen'; import { Task } from 'vs/workbench/parts/tasks/common/tasks'; import { ITaskService } from 'vs/workbench/parts/tasks/common/taskService'; +import { IExtensionService } from 'vs/platform/extensions/common/extensions'; + import * as base from './quickOpen'; @@ -34,11 +36,15 @@ class TaskEntry extends base.TaskEntry { } export class QuickOpenHandler extends base.QuickOpenHandler { + private activationPromise: TPromise; + constructor( @IQuickOpenService quickOpenService: IQuickOpenService, - @ITaskService taskService: ITaskService + @ITaskService taskService: ITaskService, + @IExtensionService extensionService: IExtensionService ) { super(quickOpenService, taskService); + this.activationPromise = extensionService.activateByEvent('onCommand:workbench.action.tasks.runTask'); } public getAriaLabel(): string { @@ -46,7 +52,9 @@ export class QuickOpenHandler extends base.QuickOpenHandler { } protected getTasks(): TPromise { - return this.taskService.tasks(); + return this.activationPromise.then(() => { + return this.taskService.tasks(); + }); } protected createEntry(taskService: ITaskService, task: Task, highlights: Model.IHighlight[]): base.TaskEntry { -- GitLab