fix #76715

src/vs/workbench/contrib/extensions/electron-browser/extensionTipsService.ts

@@ -596,29 +596,7 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
 
 		// re-schedule this bit of the operation to be off the critical path - in case glob-match is slow
 		setImmediate(async () => {
-			const installed = await this.extensionManagementService.getInstalled(ExtensionType.User);
-			if (await this.promptRecommendedExtensionForFileType(model, installed)) {
-				return;
-			}
-
-			if (fileExtension) {
-				fileExtension = fileExtension.substr(1); // Strip the dot
-			}
-			if (!fileExtension) {
-				return;
-			}
-
-			await this.extensionService.whenInstalledExtensionsRegistered();
-			const mimeTypes = guessMimeTypes(uri);
-			if (mimeTypes.length !== 1 || mimeTypes[0] !== MIME_UNKNOWN) {
-				return;
-			}
 
-			this.promptRecommendedExtensionForFileExtension(fileExtension, installed);
-		});
-	}
-
-	private async promptRecommendedExtensionForFileType(model: ITextModel, installed: ILocalExtension[]): Promise<boolean> {
 			let recommendationsToSuggest: string[] = [];
 			const now = Date.now();
 			forEach(this._availableRecommendations, entry => {
@@ -646,9 +624,32 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
 
 			const config = this.configurationService.getValue<IExtensionsConfiguration>(ConfigurationKey);
 			if (config.ignoreRecommendations || config.showRecommendationsOnlyOnDemand) {
-			return false;
+				return;
+			}
+
+			const installed = await this.extensionManagementService.getInstalled(ExtensionType.User);
+			if (await this.promptRecommendedExtensionForFileType(recommendationsToSuggest, installed)) {
+				return;
+			}
+
+			if (fileExtension) {
+				fileExtension = fileExtension.substr(1); // Strip the dot
+			}
+			if (!fileExtension) {
+				return;
+			}
+
+			await this.extensionService.whenInstalledExtensionsRegistered();
+			const mimeTypes = guessMimeTypes(uri);
+			if (mimeTypes.length !== 1 || mimeTypes[0] !== MIME_UNKNOWN) {
+				return;
+			}
+
+			this.promptRecommendedExtensionForFileExtension(fileExtension, installed);
+		});
 	}
 
+	private async promptRecommendedExtensionForFileType(recommendationsToSuggest: string[], installed: ILocalExtension[]): Promise<boolean> {
 		const importantRecommendationsIgnoreList = <string[]>JSON.parse(this.storageService.get('extensionsAssistant/importantRecommendationsIgnore', StorageScope.GLOBAL, '[]'));
 		const installedExtensionsIds = installed.reduce((result, i) => { result.add(i.identifier.id.toLowerCase()); return result; }, new Set<string>());
 		recommendationsToSuggest = recommendationsToSuggest.filter(id => {