From d4972e22a65eb294f90a93b90d3a375196f8cdd6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=A3o=20Moreno?= Date: Tue, 11 Aug 2020 20:00:16 +0200 Subject: [PATCH] fix size constraints --- .../scm/browser/scmRepositoriesViewPane.ts | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/vs/workbench/contrib/scm/browser/scmRepositoriesViewPane.ts b/src/vs/workbench/contrib/scm/browser/scmRepositoriesViewPane.ts index f32780c5ee3..503dd541418 100644 --- a/src/vs/workbench/contrib/scm/browser/scmRepositoriesViewPane.ts +++ b/src/vs/workbench/contrib/scm/browser/scmRepositoriesViewPane.ts @@ -23,6 +23,7 @@ import { IOpenerService } from 'vs/platform/opener/common/opener'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry'; import { RepositoryRenderer } from 'vs/workbench/contrib/scm/browser/scmRepositoryRenderer'; import { collectContextMenuActions, StatusBarAction, StatusBarActionViewItem } from 'vs/workbench/contrib/scm/browser/util'; +import { Orientation } from 'vs/base/browser/ui/sash/sash'; class ListDelegate implements IListVirtualDelegate { @@ -94,11 +95,13 @@ export class SCMRepositoriesViewPane extends ViewPane { this.onDidAddRepository(repository); } - this._register(this.configurationService.onDidChangeConfiguration(e => { - if (e.affectsConfiguration('scm.repositories.visible')) { - this.updateBodySize(); - } - })); + if (this.orientation === Orientation.VERTICAL) { + this._register(this.configurationService.onDidChangeConfiguration(e => { + if (e.affectsConfiguration('scm.repositories.visible')) { + this.updateBodySize(); + } + })); + } this.updateListSelection(); } @@ -128,6 +131,10 @@ export class SCMRepositoriesViewPane extends ViewPane { } private updateBodySize(): void { + if (this.orientation === Orientation.HORIZONTAL) { + return; + } + const visibleCount = this.configurationService.getValue('scm.repositories.visible'); const empty = this.list.length === 0; const size = Math.min(this.list.length, visibleCount) * 22; -- GitLab