From d3c8e64cf09b155cd9289f60a613357203190a7f Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Fri, 24 Mar 2017 20:05:56 -0700 Subject: [PATCH] use single line and underline clickable part --- .../base/browser/ui/resourceviewer/resourceViewer.ts | 11 +++++++---- .../base/browser/ui/resourceviewer/resourceviewer.css | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/vs/base/browser/ui/resourceviewer/resourceViewer.ts b/src/vs/base/browser/ui/resourceviewer/resourceViewer.ts index ab4186ee789..c65314275c0 100644 --- a/src/vs/base/browser/ui/resourceviewer/resourceViewer.ts +++ b/src/vs/base/browser/ui/resourceviewer/resourceViewer.ts @@ -160,15 +160,18 @@ export class ResourceViewer { } else { $(container) .empty() - .append($('p', { - text: nls.localize('largeImageError', "The image is too large to display in the editor.") - })) + .p({ + text: nls.localize('largeImageError', "The image is too large to display in the editor. ") + }) .append($('a', { role: 'button', class: 'open-external', - text: nls.localize('resourceOpenExternal', "Try opening the image using an external program?") + text: nls.localize('resourceOpenExternalButton', "Open image") }).on(DOM.EventType.CLICK, (e) => { openExternal(descriptor.resource); + })) + .append($('span', { + text: nls.localize('resourceOpenExternalText', ' using external program?') })); } } diff --git a/src/vs/base/browser/ui/resourceviewer/resourceviewer.css b/src/vs/base/browser/ui/resourceviewer/resourceviewer.css index ae314252914..c4badd1d2c5 100644 --- a/src/vs/base/browser/ui/resourceviewer/resourceviewer.css +++ b/src/vs/base/browser/ui/resourceviewer/resourceviewer.css @@ -52,4 +52,5 @@ .monaco-resource-viewer .open-external, .monaco-resource-viewer .open-external:hover { cursor: pointer; + text-decoration: underline; } -- GitLab