Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
d3c2ba36
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d3c2ba36
编写于
6月 16, 2017
作者:
B
Benjamin Pasero
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
better fix for NPE in editor.hide()
上级
7b3daf20
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
9 addition
and
11 deletion
+9
-11
src/vs/workbench/browser/parts/editor/editorGroupsControl.ts
src/vs/workbench/browser/parts/editor/editorGroupsControl.ts
+2
-6
src/vs/workbench/browser/parts/editor/editorPart.ts
src/vs/workbench/browser/parts/editor/editorPart.ts
+7
-5
未找到文件。
src/vs/workbench/browser/parts/editor/editorGroupsControl.ts
浏览文件 @
d3c2ba36
...
...
@@ -519,12 +519,8 @@ export class EditorGroupsControl extends Themable implements IEditorGroupsContro
// Clear Position
this
.
clearPosition
(
position
);
// Take editor container offdom and hide. Check if the editor container
// exists in case someone manages to hide an editor before it was created
const
editorContainer
=
editor
.
getContainer
();
if
(
editorContainer
)
{
editorContainer
.
offDOM
().
hide
();
}
// Take editor container offdom and hide
editor
.
getContainer
().
offDOM
().
hide
();
// Adjust layout and rochade if instructed to do so
if
(
layoutAndRochade
)
{
...
...
src/vs/workbench/browser/parts/editor/editorPart.ts
浏览文件 @
d3c2ba36
...
...
@@ -361,7 +361,7 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
// Hide active one first
if
(
editorAtPosition
)
{
this
.
doHideEditor
(
position
,
false
);
this
.
doHideEditor
(
editorAtPosition
,
position
,
false
);
}
// Create Editor
...
...
@@ -592,8 +592,11 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
// Update stacks model
this
.
modifyGroups
(()
=>
this
.
stacks
.
closeGroup
(
group
));
// Hide Editor
this
.
doHideEditor
(
position
,
true
);
// Hide Editor if there is one
const
editor
=
this
.
visibleEditors
[
position
];
if
(
editor
)
{
this
.
doHideEditor
(
editor
,
position
,
true
);
}
// Emit Change Event
this
.
_onEditorsChanged
.
fire
();
...
...
@@ -613,8 +616,7 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
}
}
private
doHideEditor
(
position
:
Position
,
layoutAndRochade
:
boolean
):
void
{
const
editor
=
this
.
visibleEditors
[
position
];
private
doHideEditor
(
editor
:
BaseEditor
,
position
:
Position
,
layoutAndRochade
:
boolean
):
void
{
// Hide in side by side control
const
rochade
=
this
.
editorGroupsControl
.
hide
(
editor
,
position
,
layoutAndRochade
);
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录