From d2148923f578ed65cec6c8a10f396933b3d1d054 Mon Sep 17 00:00:00 2001 From: Rob Lourens Date: Thu, 16 Aug 2018 18:09:53 -0700 Subject: [PATCH] Revert "Fix #56415 - 'new' tag for settings" --- src/vs/editor/common/config/commonEditorConfig.ts | 6 ++---- src/vs/workbench/electron-browser/main.contribution.ts | 3 +-- .../workbench/parts/preferences/browser/settingsEditor2.ts | 6 +----- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/src/vs/editor/common/config/commonEditorConfig.ts b/src/vs/editor/common/config/commonEditorConfig.ts index 35389354cef..07380bbb371 100644 --- a/src/vs/editor/common/config/commonEditorConfig.ts +++ b/src/vs/editor/common/config/commonEditorConfig.ts @@ -492,14 +492,12 @@ const editorConfiguration: IConfigurationNode = { 'editor.parameterHints.enabled': { 'type': 'boolean', 'default': EDITOR_DEFAULTS.contribInfo.parameterHints.enabled, - 'description': nls.localize('parameterHints.enabled', "Enables a pop-up that shows parameter documentation and type information as you type."), - 'tags': ['new'] + 'description': nls.localize('parameterHints.enabled', "Enables a pop-up that shows parameter documentation and type information as you type.") }, 'editor.parameterHints.cycle': { 'type': 'boolean', 'default': EDITOR_DEFAULTS.contribInfo.parameterHints.cycle, - 'description': nls.localize('parameterHints.cycle', "Controls whether the parameter hints menu cycles or closes when reaching the end of the list."), - 'tags': ['new'] + 'description': nls.localize('parameterHints.cycle', "Controls whether the parameter hints menu cycles or closes when reaching the end of the list.") }, 'editor.autoClosingBrackets': { 'type': 'boolean', diff --git a/src/vs/workbench/electron-browser/main.contribution.ts b/src/vs/workbench/electron-browser/main.contribution.ts index d1d7e6d8dbe..150d1754371 100644 --- a/src/vs/workbench/electron-browser/main.contribution.ts +++ b/src/vs/workbench/electron-browser/main.contribution.ts @@ -653,8 +653,7 @@ configurationRegistry.registerConfiguration({ ], 'description': nls.localize('settings.editor.desc', "Determines which settings editor to use by default."), 'default': 'ui', - 'scope': ConfigurationScope.WINDOW, - 'tags': ['new'] + 'scope': ConfigurationScope.WINDOW }, 'workbench.enableExperiments': { 'type': 'boolean', diff --git a/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts b/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts index 0f6fcf707d4..ea84a34cbad 100644 --- a/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts +++ b/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts @@ -53,7 +53,7 @@ export class SettingsEditor2 extends BaseEditor { private static NUM_INSTANCES: number = 0; private static readonly SUGGESTIONS: string[] = [ - '@modified', '@tag:usesOnlineServices', '@tag:new' + '@modified', '@tag:usesOnlineServices' ]; private defaultSettingsEditorModel: DefaultSettingsEditorModel; @@ -256,10 +256,6 @@ export class SettingsEditor2 extends BaseEditor { this.instantiationService.createInstance(FilterByTagAction, localize('filterModifiedLabel', "Show modified settings"), MODIFIED_SETTING_TAG, - this), - this.instantiationService.createInstance(FilterByTagAction, - localize('filterNewLabel', "Show new settings"), - 'new', this) ]; if (this.environmentService.appQuality !== 'stable') { -- GitLab