From c8fafc7d7382a4b4cb1066d110964a2daf104ebf Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Tue, 28 May 2019 16:12:58 +0200 Subject: [PATCH] Do not add label to task commands by default Fixes #69844 --- src/vs/workbench/contrib/tasks/common/jsonSchema_v2.ts | 2 +- src/vs/workbench/contrib/tasks/common/taskConfiguration.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/contrib/tasks/common/jsonSchema_v2.ts b/src/vs/workbench/contrib/tasks/common/jsonSchema_v2.ts index eac6a87eadb..e2d9e2be936 100644 --- a/src/vs/workbench/contrib/tasks/common/jsonSchema_v2.ts +++ b/src/vs/workbench/contrib/tasks/common/jsonSchema_v2.ts @@ -422,7 +422,7 @@ taskDescription.default = { problemMatcher: [] }; definitions.showOutputType.deprecationMessage = nls.localize( - 'JsonSchema.tasks.showOputput.deprecated', + 'JsonSchema.tasks.showOutput.deprecated', 'The property showOutput is deprecated. Use the reveal property inside the presentation property instead. See also the 1.14 release notes.' ); taskDescriptionProperties.echoCommand.deprecationMessage = nls.localize( diff --git a/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts b/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts index 5132339f26d..daf4f6a189c 100644 --- a/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts +++ b/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts @@ -1079,7 +1079,7 @@ namespace CommandConfiguration { value.args = EMPTY_ARRAY; } if (value.suppressTaskName === undefined) { - value.suppressTaskName = false; + value.suppressTaskName = (context.schemaVersion === Tasks.JsonSchemaVersion.V2_0_0); } } @@ -1711,7 +1711,7 @@ namespace Globals { } CommandConfiguration.fillDefaults(value.command, context); if (value.suppressTaskName === undefined) { - value.suppressTaskName = false; + value.suppressTaskName = (context.schemaVersion === Tasks.JsonSchemaVersion.V2_0_0); } if (value.promptOnClose === undefined) { value.promptOnClose = true; -- GitLab