From c4b89c1be68a6aa23d7bed0031e4705fd4a77e8c Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Fri, 18 Jan 2019 11:58:38 +0100 Subject: [PATCH] :lipstick: --- src/vs/workbench/common/editor/editorGroup.ts | 9 +++------ src/vs/workbench/electron-browser/main.contribution.ts | 2 +- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/vs/workbench/common/editor/editorGroup.ts b/src/vs/workbench/common/editor/editorGroup.ts index 00a275cd8fb..f8d1e48fe61 100644 --- a/src/vs/workbench/common/editor/editorGroup.ts +++ b/src/vs/workbench/common/editor/editorGroup.ts @@ -334,20 +334,17 @@ export class EditorGroup extends Disposable { // More than one editor if (this.mru.length > 1) { - let newActive: EditorInput; - if (this.closeTabsInMRUOrder) { newActive = this.mru[1]; // active editor is always first in MRU, so pick second editor after as new active - } - else { + } else { if (index === this.editors.length - 1) { newActive = this.editors[index - 1]; // last editor is closed, pick previous as new active - } - else { + } else { newActive = this.editors[index + 1]; // pick next editor as new active } } + this.setActive(newActive); } diff --git a/src/vs/workbench/electron-browser/main.contribution.ts b/src/vs/workbench/electron-browser/main.contribution.ts index d74e94e7923..f478a2cc03a 100644 --- a/src/vs/workbench/electron-browser/main.contribution.ts +++ b/src/vs/workbench/electron-browser/main.contribution.ts @@ -518,7 +518,7 @@ configurationRegistry.registerConfiguration({ }, 'workbench.editor.closeTabsInMRUOrder': { 'type': 'boolean', - 'description': nls.localize('closeTabsInMRUOrder', "Controls whether tabs are closed in most recently used order."), + 'description': nls.localize('closeTabsInMRUOrder', "Controls whether tabs are closed in most recently used order or from left to right."), 'default': true }, 'workbench.editor.showIcons': { -- GitLab