From c34bd4a314ed1f425efa74a3cc6ccb708054ad08 Mon Sep 17 00:00:00 2001 From: Alex Dima Date: Sat, 14 Jan 2017 11:29:53 +0100 Subject: [PATCH] Simplify addStandardDisposableListener --- src/vs/base/browser/dom.ts | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/src/vs/base/browser/dom.ts b/src/vs/base/browser/dom.ts index 567e9d85db4..9ac2e1f1dfa 100644 --- a/src/vs/base/browser/dom.ts +++ b/src/vs/base/browser/dom.ts @@ -235,21 +235,7 @@ export let addStandardDisposableListener: IAddStandardDisposableListenerSignatur wrapHandler = _wrapAsStandardKeyboardEvent(handler); } - node.addEventListener(type, wrapHandler, useCapture || false); - return { - dispose: function () { - if (!wrapHandler) { - // Already removed - return; - } - node.removeEventListener(type, wrapHandler, useCapture || false); - - // Prevent leakers from holding on to the dom node or handler func - wrapHandler = null; - node = null; - handler = null; - } - }; + return addDisposableListener(node, type, wrapHandler, useCapture); }; export function addDisposableNonBubblingMouseOutListener(node: Element, handler: (event: MouseEvent) => void): IDisposable { -- GitLab