From c27e5de6f0efc28090052ef17170dcaac2104f0c Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Wed, 8 Nov 2017 11:20:19 +0100 Subject: [PATCH] fix tests --- .../api/extHostLanguageFeatures.test.ts | 22 ++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/src/vs/workbench/test/electron-browser/api/extHostLanguageFeatures.test.ts b/src/vs/workbench/test/electron-browser/api/extHostLanguageFeatures.test.ts index eaed5845910..49a7be6f3dd 100644 --- a/src/vs/workbench/test/electron-browser/api/extHostLanguageFeatures.test.ts +++ b/src/vs/workbench/test/electron-browser/api/extHostLanguageFeatures.test.ts @@ -733,24 +733,40 @@ suite('ExtHostLanguageFeatures', function () { // --- rename - test('Rename, evil provider 1/2', function () { + test('Rename, evil provider 0/2', function () { disposables.push(extHost.registerRenameProvider(defaultSelector, { provideRenameEdits(): any { - throw Error('evil'); + throw new class Foo { }; } })); return threadService.sync().then(() => { return rename(model, new EditorPosition(1, 1), 'newName').then(value => { - throw new Error(''); + throw Error(); }, err => { // expected }); }); }); + test('Rename, evil provider 1/2', function () { + + disposables.push(extHost.registerRenameProvider(defaultSelector, { + provideRenameEdits(): any { + throw Error('evil'); + } + })); + + return threadService.sync().then(() => { + + return rename(model, new EditorPosition(1, 1), 'newName').then(value => { + assert.equal(value.rejectReason, 'evil'); + }); + }); + }); + test('Rename, evil provider 2/2', function () { disposables.push(extHost.registerRenameProvider('*', { -- GitLab