From c17ffc2822cbf5a91efe0fceaf3ffd7cb8411de8 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Mon, 17 Jul 2017 12:47:52 +0200 Subject: [PATCH] fix #26511 --- src/vs/base/common/filters.ts | 2 +- src/vs/base/test/common/filters.test.ts | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/vs/base/common/filters.ts b/src/vs/base/common/filters.ts index 228bae7cc61..6cbb0968e9f 100644 --- a/src/vs/base/common/filters.ts +++ b/src/vs/base/common/filters.ts @@ -381,7 +381,7 @@ function initTable() { for (let i = 1; i <= 100; i++) { row.push(-i); } - for (let i = 0; i < 100; i++) { + for (let i = 0; i <= 100; i++) { let thisRow = row.slice(0); thisRow[0] = -i; table.push(thisRow); diff --git a/src/vs/base/test/common/filters.test.ts b/src/vs/base/test/common/filters.test.ts index 663c7cccf3d..abda7f3352b 100644 --- a/src/vs/base/test/common/filters.test.ts +++ b/src/vs/base/test/common/filters.test.ts @@ -329,6 +329,13 @@ suite('Filters', () => { assertMatches('f', ':foo', ':^foo', fuzzyScore); }); + test('Cannot set property \'1\' of undefined, #26511', function () { + let word = new Array(123).join('a'); + let pattern = new Array(120).join('a'); + fuzzyScore(pattern, word); + assert.ok(true); // must not explode + }); + test('Vscode 1.12 no longer obeys \'sortText\' in completion items (from language server), #26096', function () { assertMatches(' ', ' group', undefined, fuzzyScore); assertMatches(' g', ' group', ' ^group', fuzzyScore); -- GitLab