From bd66f3ff669b13ba702a62cf021f0a4a942f70a8 Mon Sep 17 00:00:00 2001 From: Christof Marti Date: Wed, 31 Jan 2018 16:11:57 +0100 Subject: [PATCH] Randomize test name to avoid collision when executing in parallel (fixes #42614) --- .../credentials/test/node/keytar.test.ts | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/vs/platform/credentials/test/node/keytar.test.ts b/src/vs/platform/credentials/test/node/keytar.test.ts index 5ae212f9b83..68e724bbccb 100644 --- a/src/vs/platform/credentials/test/node/keytar.test.ts +++ b/src/vs/platform/credentials/test/node/keytar.test.ts @@ -17,10 +17,20 @@ suite('Keytar', () => { } (async () => { const keytar = await import('keytar'); - await keytar.setPassword('VSCode Test', 'foo', 'bar'); - assert.equal(await keytar.getPassword('VSCode Test', 'foo'), 'bar'); - await keytar.deletePassword('VSCode Test', 'foo'); - assert.equal(await keytar.getPassword('VSCode Test', 'foo'), undefined); + const name = `VSCode Test ${Math.floor(Math.random() * 1e9)}`; + try { + await keytar.setPassword(name, 'foo', 'bar'); + assert.equal(await keytar.getPassword(name, 'foo'), 'bar'); + await keytar.deletePassword(name, 'foo'); + assert.equal(await keytar.getPassword(name, 'foo'), undefined); + } catch (err) { + // try to clean up + try { + await keytar.deletePassword(name, 'foo'); + } finally { + throw err; + } + } })().then(done, done); }); }); \ No newline at end of file -- GitLab