From bd08ccfc3249587f89755b56782eeebff30c8584 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Fri, 31 May 2019 10:07:20 -0700 Subject: [PATCH] Actually fix the issue typeof NaN is number :/ --- src/vs/workbench/contrib/terminal/node/terminalProcess.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/terminal/node/terminalProcess.ts b/src/vs/workbench/contrib/terminal/node/terminalProcess.ts index c01ec8da5fe..3005784b6e9 100644 --- a/src/vs/workbench/contrib/terminal/node/terminalProcess.ts +++ b/src/vs/workbench/contrib/terminal/node/terminalProcess.ts @@ -200,7 +200,7 @@ export class TerminalProcess implements ITerminalChildProcess, IDisposable { if (this._isDisposed) { return; } - if (typeof cols !== 'number' || typeof rows !== 'number') { + if (typeof cols !== 'number' || typeof rows !== 'number' || isNaN(cols) || isNaN(rows)) { return; } // Ensure that cols and rows are always >= 1, this prevents a native -- GitLab