From b98c3f7d79bbd8f9c0ea05b73f273a5d2010cb27 Mon Sep 17 00:00:00 2001
From: XVincentX <vincenzo@apiary.io>
Date: Thu, 15 Sep 2016 09:54:48 +0200
Subject: [PATCH] Add hasChangelog method to display the tab eventually

---
 .../parts/extensions/electron-browser/extensionEditor.ts     | 5 ++++-
 .../parts/extensions/electron-browser/extensions.ts          | 1 +
 .../electron-browser/extensionsWorkbenchService.ts           | 4 ++++
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts
index 18237bf8a94..4d5ccef16ca 100644
--- a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts
+++ b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts
@@ -254,7 +254,10 @@ export class ExtensionEditor extends BaseEditor {
 		this.navbar.onChange(this.onNavbarChange.bind(this, extension), this, this.transientDisposables);
 		this.navbar.push(NavbarSection.Readme, localize('details', "Details"));
 		this.navbar.push(NavbarSection.Contributions, localize('contributions', "Contributions"));
-		this.navbar.push(NavbarSection.Changelog, localize('changelog', "Changelog"));
+
+		if (extension.hasChangelog) {
+			this.navbar.push(NavbarSection.Changelog, localize('changelog', "Changelog"));
+		}
 
 		this.content.innerHTML = '';
 
diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensions.ts b/src/vs/workbench/parts/extensions/electron-browser/extensions.ts
index 5db4602be2a..6966da5edce 100644
--- a/src/vs/workbench/parts/extensions/electron-browser/extensions.ts
+++ b/src/vs/workbench/parts/extensions/electron-browser/extensions.ts
@@ -42,6 +42,7 @@ export interface IExtension {
 	telemetryData: any;
 	getManifest(): TPromise<IExtensionManifest>;
 	getReadme(): TPromise<string>;
+	hasChangelog : boolean;
 	getChangelog() : TPromise<string>;
 }
 
diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts
index c384c617964..7cab830d8c2 100644
--- a/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts
+++ b/src/vs/workbench/parts/extensions/electron-browser/extensionsWorkbenchService.ts
@@ -187,6 +187,10 @@ class Extension implements IExtension {
 		return this.galleryService.getAsset(readmeUrl).then(asText);
 	}
 
+	get hasChangelog() : boolean {
+		return !!(this.local && this.local.changelogUrl ? this.local.changelogUrl : '');
+	}
+
 	getChangelog() : TPromise<string> {
 		const changelogUrl = this.local && this.local.changelogUrl ? this.local.changelogUrl : '';
 
-- 
GitLab