From b42d1d5efae056c2f3c13a696525c42f66760c5b Mon Sep 17 00:00:00 2001
From: rebornix <penn.lv@gmail.com>
Date: Tue, 25 Feb 2020 16:25:15 -0800
Subject: [PATCH] remove unused list hack

---
 src/vs/base/browser/ui/list/list.ts                           | 1 -
 src/vs/base/browser/ui/list/listView.ts                       | 1 +
 .../contrib/notebook/browser/renderers/cellRenderer.ts        | 4 ----
 3 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/vs/base/browser/ui/list/list.ts b/src/vs/base/browser/ui/list/list.ts
index 7cbba460af7..f07e22e1bee 100644
--- a/src/vs/base/browser/ui/list/list.ts
+++ b/src/vs/base/browser/ui/list/list.ts
@@ -12,7 +12,6 @@ export interface IListVirtualDelegate<T> {
 	getTemplateId(element: T): string;
 	hasDynamicHeight?(element: T): boolean;
 	setDynamicHeight?(element: T, height: number): void;
-	getDynamicHeight?(element: T): number;
 }
 
 export interface IListRenderer<T, TTemplateData> {
diff --git a/src/vs/base/browser/ui/list/listView.ts b/src/vs/base/browser/ui/list/listView.ts
index 3e00feb4527..bb4b0e1c763 100644
--- a/src/vs/base/browser/ui/list/listView.ts
+++ b/src/vs/base/browser/ui/list/listView.ts
@@ -1172,6 +1172,7 @@ export class ListView<T> implements ISpliceable<T>, IDisposable {
 
 		if (this.virtualDelegate.hasDynamicHeight) {
 			if (!this.virtualDelegate.hasDynamicHeight(item.element)) {
+				// if the item doesn't have dynamic height, don't check its height again
 				return 0;
 			}
 		} else {
diff --git a/src/vs/workbench/contrib/notebook/browser/renderers/cellRenderer.ts b/src/vs/workbench/contrib/notebook/browser/renderers/cellRenderer.ts
index 0da78f7a5ee..db3b464a957 100644
--- a/src/vs/workbench/contrib/notebook/browser/renderers/cellRenderer.ts
+++ b/src/vs/workbench/contrib/notebook/browser/renderers/cellRenderer.ts
@@ -40,10 +40,6 @@ export class NotebookCellListDelegate implements IListVirtualDelegate<CellViewMo
 		return element.hasDynamicHeight();
 	}
 
-	getDynamicHeight(element: CellViewModel) {
-		return element.dynamicHeight || 0;
-	}
-
 	getTemplateId(element: CellViewModel): string {
 		if (element.cellType === 'markdown') {
 			return MarkdownCellRenderer.TEMPLATE_ID;
-- 
GitLab