diff --git a/src/vs/base/browser/ui/list/list.ts b/src/vs/base/browser/ui/list/list.ts index 7cbba460af72e055ad9662e1501035249394b870..f07e22e1bee4721a78dab9616d54c54b298370b6 100644 --- a/src/vs/base/browser/ui/list/list.ts +++ b/src/vs/base/browser/ui/list/list.ts @@ -12,7 +12,6 @@ export interface IListVirtualDelegate { getTemplateId(element: T): string; hasDynamicHeight?(element: T): boolean; setDynamicHeight?(element: T, height: number): void; - getDynamicHeight?(element: T): number; } export interface IListRenderer { diff --git a/src/vs/base/browser/ui/list/listView.ts b/src/vs/base/browser/ui/list/listView.ts index 3e00feb452747e9a7f141c2b44290e517f8f4cb3..bb4b0e1c763d23d48f589e36ff33bc7cee4d9343 100644 --- a/src/vs/base/browser/ui/list/listView.ts +++ b/src/vs/base/browser/ui/list/listView.ts @@ -1172,6 +1172,7 @@ export class ListView implements ISpliceable, IDisposable { if (this.virtualDelegate.hasDynamicHeight) { if (!this.virtualDelegate.hasDynamicHeight(item.element)) { + // if the item doesn't have dynamic height, don't check its height again return 0; } } else { diff --git a/src/vs/workbench/contrib/notebook/browser/renderers/cellRenderer.ts b/src/vs/workbench/contrib/notebook/browser/renderers/cellRenderer.ts index 0da78f7a5ee455648f52e9a35d3791f3735f75a9..db3b464a957b5b918924d1ce857927142f1daeef 100644 --- a/src/vs/workbench/contrib/notebook/browser/renderers/cellRenderer.ts +++ b/src/vs/workbench/contrib/notebook/browser/renderers/cellRenderer.ts @@ -40,10 +40,6 @@ export class NotebookCellListDelegate implements IListVirtualDelegate