From b3e928809eb60402dc01c2df3836ae80014ab24e Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Mon, 12 Sep 2016 17:20:30 +0200 Subject: [PATCH] Unable to open workspace settings if "workbench.settings.openDefaultSettings": false (fixes #11888) --- src/vs/workbench/browser/actions/openSettings.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/browser/actions/openSettings.ts b/src/vs/workbench/browser/actions/openSettings.ts index dd151ac7453..ae5232d883b 100644 --- a/src/vs/workbench/browser/actions/openSettings.ts +++ b/src/vs/workbench/browser/actions/openSettings.ts @@ -110,10 +110,11 @@ export class BaseOpenSettingsAction extends BaseTwoEditorsAction { return this.openTwoEditors(DefaultSettingsInput.getInstance(this.instantiationService, this.configurationService), settingsResource, emptySettingsContents); } - return this.editorService.openEditor({ + // Create as needed and open in editor + return this.createIfNotExists(settingsResource, emptySettingsContents).then(() => this.editorService.openEditor({ resource: settingsResource, options: { pinned: true } - }).then(() => null); + }).then(() => null)); } } -- GitLab