From b29fec000b96d7912d56499a496284156c9aa891 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Mon, 8 Jul 2019 12:51:24 +0200 Subject: [PATCH] fix add after dispose issues --- src/vs/editor/contrib/snippet/snippetController2.ts | 2 +- src/vs/editor/contrib/suggest/suggestController.ts | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/editor/contrib/snippet/snippetController2.ts b/src/vs/editor/contrib/snippet/snippetController2.ts index 75e8ad4ff86..a09aa96db74 100644 --- a/src/vs/editor/contrib/snippet/snippetController2.ts +++ b/src/vs/editor/contrib/snippet/snippetController2.ts @@ -208,7 +208,7 @@ export class SnippetController2 implements IEditorContribution { this._inSnippet.reset(); this._hasPrevTabstop.reset(); this._hasNextTabstop.reset(); - dispose(this._snippetListener); + this._snippetListener.clear(); dispose(this._session); this._session = undefined; this._modelVersionId = -1; diff --git a/src/vs/editor/contrib/suggest/suggestController.ts b/src/vs/editor/contrib/suggest/suggestController.ts index 600cfc52273..aac58cf801d 100644 --- a/src/vs/editor/contrib/suggest/suggestController.ts +++ b/src/vs/editor/contrib/suggest/suggestController.ts @@ -149,6 +149,7 @@ export class SuggestController implements IEditorContribution { } dispose(): void { + this._alternatives.dispose(); this._toDispose.dispose(); this._widget.dispose(); this._model.dispose(); -- GitLab