From b29cb61077a97e3d0be8c17a251a2adbb20d2d9e Mon Sep 17 00:00:00 2001 From: pi1024e Date: Sun, 21 Jul 2019 12:25:44 -0400 Subject: [PATCH] Code Quality Fixes --- .../contrib/inPlaceReplace/inPlaceReplace.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/vs/editor/contrib/inPlaceReplace/inPlaceReplace.ts b/src/vs/editor/contrib/inPlaceReplace/inPlaceReplace.ts index 195d83b849c..9c501418af4 100644 --- a/src/vs/editor/contrib/inPlaceReplace/inPlaceReplace.ts +++ b/src/vs/editor/contrib/inPlaceReplace/inPlaceReplace.ts @@ -83,7 +83,7 @@ class InPlaceReplaceController implements IEditorContribution { return this.currentRequest.then(result => { - if (!result || !result.range || !result.value) { + if (!(result && result.range && result.value)) { // No proper result return; } @@ -151,10 +151,10 @@ class InPlaceReplaceUp extends EditorAction { public run(accessor: ServicesAccessor, editor: ICodeEditor): Promise | undefined { const controller = InPlaceReplaceController.get(editor); - if (!controller) { - return Promise.resolve(undefined); + if (controller) { + return controller.run(this.id, true); } - return controller.run(this.id, true); + return Promise.resolve(undefined); } } @@ -176,10 +176,10 @@ class InPlaceReplaceDown extends EditorAction { public run(accessor: ServicesAccessor, editor: ICodeEditor): Promise | undefined { const controller = InPlaceReplaceController.get(editor); - if (!controller) { - return Promise.resolve(undefined); + if (controller) { + return controller.run(this.id, false); } - return controller.run(this.id, false); + return Promise.resolve(undefined); } } -- GitLab