From aee13817498b450c8271b2b6990cbca5a6aec7c7 Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Wed, 4 Oct 2017 12:34:45 +0200 Subject: [PATCH] Smoke tests: Add a comma at the end while adding a setting --- test/smoke/src/areas/preferences/preferences.test.ts | 5 +---- test/smoke/src/areas/preferences/settings.ts | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/test/smoke/src/areas/preferences/preferences.test.ts b/test/smoke/src/areas/preferences/preferences.test.ts index df2aa0eef99..795c3aba1d2 100644 --- a/test/smoke/src/areas/preferences/preferences.test.ts +++ b/test/smoke/src/areas/preferences/preferences.test.ts @@ -20,10 +20,7 @@ describe('Preferences', () => { await app.screenCapturer.capture('line numbers'); assert.ok(!!lineNumbers.length, 'Line numbers are not present in the editor before disabling them.'); - await app.workbench.settingsEditor.openUserSettings(); - await app.workbench.settingsEditor.focusEditableSettings(); - await app.client.keys(`"editor.lineNumbers": "off"`); - await app.workbench.saveOpenedFile(); + await app.workbench.settingsEditor.addUserSetting('editor.lineNumbers', '"off"'); await app.workbench.selectTab('app.js'); lineNumbers = await app.client.waitForElements('.line-numbers', result => !result || result.length === 0); diff --git a/test/smoke/src/areas/preferences/settings.ts b/test/smoke/src/areas/preferences/settings.ts index 094fda6a9a0..b771b3702cc 100644 --- a/test/smoke/src/areas/preferences/settings.ts +++ b/test/smoke/src/areas/preferences/settings.ts @@ -30,9 +30,8 @@ export class SettingsEditor { async addUserSetting(setting: string, value: string): Promise { await this.openUserSettings(); - // await this.spectron.wait(1); await this.focusEditableSettings(); - await this.spectron.client.keys(`"${setting}": ${value}`); + await this.spectron.client.keys(`"${setting}": ${value},`); await this.spectron.workbench.saveOpenedFile(); } } \ No newline at end of file -- GitLab