From ad86b598754dbfbb5970130784a1e4e44dfa84cd Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Wed, 18 Jul 2018 16:00:02 +0200 Subject: [PATCH] move perf-mark for local storage access to index.js --- src/vs/workbench/electron-browser/bootstrap/index.js | 9 +++++++-- src/vs/workbench/electron-browser/main.ts | 3 --- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/vs/workbench/electron-browser/bootstrap/index.js b/src/vs/workbench/electron-browser/bootstrap/index.js index fce3512c554..231a22d172e 100644 --- a/src/vs/workbench/electron-browser/bootstrap/index.js +++ b/src/vs/workbench/electron-browser/bootstrap/index.js @@ -96,14 +96,19 @@ function showPartsSplash(configuration) { keep = true; } - let structure = window.localStorage.getItem(key); + // TODO@Ben remove me after a while + perf.mark('willAccessLocalStorage'); + let storage = window.localStorage; + perf.mark('didAccessLocalStorage'); + + let structure = storage.getItem(key); if (structure) { let splash = document.createElement('div'); splash.innerHTML = structure; document.body.appendChild(splash); } if (!keep) { - window.localStorage.removeItem(key); + storage.removeItem(key); } } diff --git a/src/vs/workbench/electron-browser/main.ts b/src/vs/workbench/electron-browser/main.ts index e8b8ff1a771..e9ae397db28 100644 --- a/src/vs/workbench/electron-browser/main.ts +++ b/src/vs/workbench/electron-browser/main.ts @@ -195,10 +195,7 @@ function createStorageService(workspaceService: IWorkspaceContextService, enviro if (disableStorage) { storage = inMemoryLocalStorageInstance; } else { - // TODO@Ben remove me after a while - perf.mark('willAccessLocalStorage'); storage = window.localStorage; - perf.mark('didAccessLocalStorage'); } return new StorageService(storage, storage, workspaceId, secondaryWorkspaceId); -- GitLab