From ad7e861dbb9127e919bc686da162b19cbb7e2391 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Wed, 6 Apr 2016 18:15:32 -0700 Subject: [PATCH] Disable welcome page when user is root Fixes #3068 --- .../parts/gettingStarted/common/abstractGettingStarted.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/gettingStarted/common/abstractGettingStarted.ts b/src/vs/workbench/parts/gettingStarted/common/abstractGettingStarted.ts index 29d469a1e73..853d9ae7154 100644 --- a/src/vs/workbench/parts/gettingStarted/common/abstractGettingStarted.ts +++ b/src/vs/workbench/parts/gettingStarted/common/abstractGettingStarted.ts @@ -34,8 +34,11 @@ export abstract class AbstractGettingStarted implements IWorkbenchContribution { protected handleWelcome(): void { let firstStartup = !this.storageService.get(AbstractGettingStarted.hideWelcomeSettingskey); + let isRootUser = process.getuid() === 0; - if (firstStartup && this.welcomePageURL) { + // Don't open the welcome page as the root user, This is due to a bug with xdg-open which + // recommends against running itself as root. + if (firstStartup && this.welcomePageURL && !isRootUser) { this.telemetryService.getTelemetryInfo().then(info=>{ let url = this.getUrl(info); this.openExternal(url); -- GitLab