diff --git a/src/vs/workbench/contrib/tags/electron-browser/workspaceTags.ts b/src/vs/workbench/contrib/tags/electron-browser/workspaceTags.ts index 1d722fdf6ecfd44a8814c6e57cb976ba31aba746..357ede3af3ee4f4c9fa1b6c652ebb2154b9700f4 100644 --- a/src/vs/workbench/contrib/tags/electron-browser/workspaceTags.ts +++ b/src/vs/workbench/contrib/tags/electron-browser/workspaceTags.ts @@ -58,7 +58,7 @@ export class WorkspaceTags implements IWorkbenchContribution { this.getWorkspaceInformation().then(stats => this.diagnosticsService.reportWorkspaceStats(stats)); } - async reportWindowsEdition(): Promise { + private async reportWindowsEdition(): Promise { if (!isWindows) { return; } diff --git a/src/vs/workbench/services/accessibility/electron-sandbox/accessibilityService.ts b/src/vs/workbench/services/accessibility/electron-sandbox/accessibilityService.ts index 2532a631061828f6a9ff7fb9f7ec05dad1aa97c9..bc25046101611fe7126fbbda2b4b0671ef58a1f6 100644 --- a/src/vs/workbench/services/accessibility/electron-sandbox/accessibilityService.ts +++ b/src/vs/workbench/services/accessibility/electron-sandbox/accessibilityService.ts @@ -29,6 +29,7 @@ export class NativeAccessibilityService extends AccessibilityService implements declare readonly _serviceBrand: undefined; private didSendTelemetry = false; + private shouldAlwaysUnderlineAccessKeys: boolean | undefined = undefined; constructor( @INativeWorkbenchEnvironmentService environmentService: INativeWorkbenchEnvironmentService, @@ -46,8 +47,12 @@ export class NativeAccessibilityService extends AccessibilityService implements return false; } - const value = await this.nativeHostService.windowsGetStringRegKey('HKEY_CURRENT_USER', 'Control Panel\\Accessibility\\Keyboard Preference', 'On'); - return value === '1'; + if (typeof this.shouldAlwaysUnderlineAccessKeys !== 'boolean') { + const windowsKeyboardAccessibility = await this.nativeHostService.windowsGetStringRegKey('HKEY_CURRENT_USER', 'Control Panel\\Accessibility\\Keyboard Preference', 'On'); + this.shouldAlwaysUnderlineAccessKeys = (windowsKeyboardAccessibility === '1'); + } + + return this.shouldAlwaysUnderlineAccessKeys; } setAccessibilitySupport(accessibilitySupport: AccessibilitySupport): void {