From a94b94ff575293d3c6a1131c37c8768e16b520ae Mon Sep 17 00:00:00 2001 From: Rachel Macfarlane Date: Fri, 25 Jan 2019 15:41:35 -0800 Subject: [PATCH] Fix #52562, Process Explorer: NVDA reads the whole table dimension every time before reading each cell value --- .../processExplorer/media/processExplorer.css | 5 ++++- .../electron-browser/processExplorer/processExplorer.html | 2 +- .../electron-browser/processExplorer/processExplorerMain.ts | 3 ++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/vs/code/electron-browser/processExplorer/media/processExplorer.css b/src/vs/code/electron-browser/processExplorer/media/processExplorer.css index 312929a2b46..2691208f2a2 100644 --- a/src/vs/code/electron-browser/processExplorer/media/processExplorer.css +++ b/src/vs/code/electron-browser/processExplorer/media/processExplorer.css @@ -56,7 +56,7 @@ table { width: 100%; table-layout: fixed; } -th { +th[scope='col'] { vertical-align: bottom; border-bottom: 1px solid #cccccc; padding: .5rem; @@ -80,6 +80,9 @@ td { .data { white-space: pre; padding-left: .5rem; + font-weight: normal; + text-align: left; + height: 22px; } tbody > tr:hover { diff --git a/src/vs/code/electron-browser/processExplorer/processExplorer.html b/src/vs/code/electron-browser/processExplorer/processExplorer.html index 366bdda9d4e..3ef3be23f8f 100644 --- a/src/vs/code/electron-browser/processExplorer/processExplorer.html +++ b/src/vs/code/electron-browser/processExplorer/processExplorer.html @@ -8,7 +8,7 @@ -
+
diff --git a/src/vs/code/electron-browser/processExplorer/processExplorerMain.ts b/src/vs/code/electron-browser/processExplorer/processExplorerMain.ts index 96b66228f0d..a9e8f38c810 100644 --- a/src/vs/code/electron-browser/processExplorer/processExplorerMain.ts +++ b/src/vs/code/electron-browser/processExplorer/processExplorerMain.ts @@ -152,7 +152,8 @@ function updateProcessInfo(processList): void { pid.classList.add('centered'); pid.textContent = p.pid; - const name = document.createElement('td'); + const name = document.createElement('th'); + name.scope = 'row'; name.classList.add('data'); name.title = p.cmd; name.textContent = p.formattedName; -- GitLab