From a8f2db516b6ff1ddfba9f3b249fbcf624921752e Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Thu, 16 Jan 2020 13:02:26 +0100 Subject: [PATCH] slightly more compact dto, no need to send false --- src/vs/workbench/api/common/extHost.protocol.ts | 6 +++--- src/vs/workbench/api/common/extHostLanguageFeatures.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/api/common/extHost.protocol.ts b/src/vs/workbench/api/common/extHost.protocol.ts index c14f1d0b26f..2d08ee74397 100644 --- a/src/vs/workbench/api/common/extHost.protocol.ts +++ b/src/vs/workbench/api/common/extHost.protocol.ts @@ -1007,7 +1007,7 @@ export interface ISuggestDataDto { [ISuggestDataDtoField.documentation]?: string | IMarkdownString; [ISuggestDataDtoField.sortText]?: string; [ISuggestDataDtoField.filterText]?: string; - [ISuggestDataDtoField.preselect]?: boolean; + [ISuggestDataDtoField.preselect]?: true; [ISuggestDataDtoField.insertText]?: string; [ISuggestDataDtoField.insertTextRules]?: modes.CompletionItemInsertTextRule; [ISuggestDataDtoField.range]?: IRange | { insert: IRange, replace: IRange; }; @@ -1023,8 +1023,8 @@ export interface ISuggestResultDto { x?: number; a: { insert: IRange, replace: IRange; }; b: ISuggestDataDto[]; - c?: boolean; - d?: boolean; + c?: true; + d?: true; } export interface ISignatureHelpDto { diff --git a/src/vs/workbench/api/common/extHostLanguageFeatures.ts b/src/vs/workbench/api/common/extHostLanguageFeatures.ts index c440c5a3f14..20cc1a12f77 100644 --- a/src/vs/workbench/api/common/extHostLanguageFeatures.ts +++ b/src/vs/workbench/api/common/extHostLanguageFeatures.ts @@ -890,7 +890,7 @@ class SuggestAdapter { [extHostProtocol.ISuggestDataDtoField.documentation]: typeof item.documentation === 'undefined' ? undefined : typeConvert.MarkdownString.fromStrict(item.documentation), [extHostProtocol.ISuggestDataDtoField.sortText]: item.sortText, [extHostProtocol.ISuggestDataDtoField.filterText]: item.filterText, - [extHostProtocol.ISuggestDataDtoField.preselect]: item.preselect, + [extHostProtocol.ISuggestDataDtoField.preselect]: item.preselect || undefined, [extHostProtocol.ISuggestDataDtoField.insertTextRules]: item.keepWhitespace ? modes.CompletionItemInsertTextRule.KeepWhitespace : 0, [extHostProtocol.ISuggestDataDtoField.commitCharacters]: item.commitCharacters, [extHostProtocol.ISuggestDataDtoField.additionalTextEdits]: item.additionalTextEdits && item.additionalTextEdits.map(typeConvert.TextEdit.from), -- GitLab