From a2af83d50a7a22ffc717943e818aeabd22b767ce Mon Sep 17 00:00:00 2001 From: katainaka0503 Date: Mon, 20 Mar 2017 15:16:23 +0900 Subject: [PATCH] Introduce minimum threshold --- src/typings/jschardet.d.ts | 4 ++++ src/vs/base/node/encoding.ts | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/typings/jschardet.d.ts b/src/typings/jschardet.d.ts index 5389e32b3c0..9c553b129eb 100644 --- a/src/typings/jschardet.d.ts +++ b/src/typings/jschardet.d.ts @@ -4,4 +4,8 @@ declare module 'jschardet' { confidence: number } export function detect(buffer: NodeBuffer): IDetectedMap; + + export const Constants: { + MINIMUM_THRESHOLD: number, + } } \ No newline at end of file diff --git a/src/vs/base/node/encoding.ts b/src/vs/base/node/encoding.ts index f6b9ae6d7c5..99eea2a9efd 100644 --- a/src/vs/base/node/encoding.ts +++ b/src/vs/base/node/encoding.ts @@ -95,7 +95,11 @@ export function detectEncodingByBOM(file: string): TPromise { return stream.readExactlyByFile(file, 3).then(({ buffer, bytesRead }) => detectEncodingByBOMFromBuffer(buffer, bytesRead)); } +const MINIMUM_THRESHOLD = 0.2; //Todo. Decide how much this should be. + const IGNORE_ENCODINGS = ['ascii', 'utf-8', 'utf-16', 'utf-32']; + +jschardet.Constants.MINIMUM_THRESHOLD = MINIMUM_THRESHOLD; /** * Guesses the encoding from buffer. */ -- GitLab