From 9e411a5fd3026e1a42f1b1a303bab376746d8ee5 Mon Sep 17 00:00:00 2001 From: Ramya Achutha Rao Date: Thu, 26 Jul 2018 17:21:32 -0700 Subject: [PATCH] Renaming tag for settings for online services #54354 --- extensions/git/package.json | 2 +- extensions/typescript-language-features/package.json | 2 +- src/vs/platform/telemetry/common/telemetryService.ts | 2 +- src/vs/platform/update/node/update.config.contribution.ts | 6 +++--- src/vs/workbench/electron-browser/main.contribution.ts | 2 +- .../extensions/electron-browser/extensions.contribution.ts | 4 ++-- .../workbench/parts/preferences/browser/settingsEditor2.ts | 6 +++--- src/vs/workbench/parts/preferences/browser/settingsTree.ts | 2 +- .../crashReporter/electron-browser/crashReporterService.ts | 2 +- 9 files changed, 14 insertions(+), 14 deletions(-) diff --git a/extensions/git/package.json b/extensions/git/package.json index 61575483e42..efe0d50e2e1 100644 --- a/extensions/git/package.json +++ b/extensions/git/package.json @@ -912,7 +912,7 @@ "type": "boolean", "description": "%config.autofetch%", "default": false, - "tags": ["backgroundOnlineFeature"] + "tags": ["usesOnlineServices"] }, "git.confirmSync": { "type": "boolean", diff --git a/extensions/typescript-language-features/package.json b/extensions/typescript-language-features/package.json index 46bca84de1a..6ba67c823ab 100644 --- a/extensions/typescript-language-features/package.json +++ b/extensions/typescript-language-features/package.json @@ -74,7 +74,7 @@ "default": false, "description": "%typescript.disableAutomaticTypeAcquisition%", "scope": "window", - "tags": ["backgroundOnlineFeature"] + "tags": ["usesOnlineServices"] }, "typescript.npm": { "type": [ diff --git a/src/vs/platform/telemetry/common/telemetryService.ts b/src/vs/platform/telemetry/common/telemetryService.ts index 0edfc7c942b..f30292529f7 100644 --- a/src/vs/platform/telemetry/common/telemetryService.ts +++ b/src/vs/platform/telemetry/common/telemetryService.ts @@ -168,7 +168,7 @@ Registry.as(Extensions.Configuration).registerConfigurat 'type': 'boolean', 'description': localize('telemetry.enableTelemetry', "Enable usage data and errors to be sent to Microsoft."), 'default': true, - 'tags': ['backgroundOnlineFeature'] + 'tags': ['usesOnlineServices'] } } }); \ No newline at end of file diff --git a/src/vs/platform/update/node/update.config.contribution.ts b/src/vs/platform/update/node/update.config.contribution.ts index 42e989b58e7..7c4cc968e67 100644 --- a/src/vs/platform/update/node/update.config.contribution.ts +++ b/src/vs/platform/update/node/update.config.contribution.ts @@ -22,20 +22,20 @@ configurationRegistry.registerConfiguration({ 'default': 'default', 'scope': ConfigurationScope.APPLICATION, 'description': nls.localize('updateChannel', "Configure whether you receive automatic updates from an update channel. Requires a restart after change."), - 'tags': ['backgroundOnlineFeature'] + 'tags': ['usesOnlineServices'] }, 'update.enableWindowsBackgroundUpdates': { 'type': 'boolean', 'default': true, 'scope': ConfigurationScope.APPLICATION, 'description': nls.localize('enableWindowsBackgroundUpdates', "Enables Windows background updates."), - 'tags': ['backgroundOnlineFeature'] + 'tags': ['usesOnlineServices'] }, 'update.showReleaseNotes': { 'type': 'boolean', 'default': true, 'description': nls.localize('showReleaseNotes', "Show Release Notes after an update."), - 'tags': ['backgroundOnlineFeature'] + 'tags': ['usesOnlineServices'] } } }); diff --git a/src/vs/workbench/electron-browser/main.contribution.ts b/src/vs/workbench/electron-browser/main.contribution.ts index e6ed4bc6b2a..3753a536e3c 100644 --- a/src/vs/workbench/electron-browser/main.contribution.ts +++ b/src/vs/workbench/electron-browser/main.contribution.ts @@ -489,7 +489,7 @@ configurationRegistry.registerConfiguration({ 'description': nls.localize('enableNaturalLanguageSettingsSearch', "Controls whether to enable the natural language search mode for settings."), 'default': true, 'scope': ConfigurationScope.WINDOW, - 'tags': ['backgroundOnlineFeature'] + 'tags': ['usesOnlineServices'] }, 'workbench.settings.settingsSearchTocBehavior': { 'type': 'string', diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensions.contribution.ts b/src/vs/workbench/parts/extensions/electron-browser/extensions.contribution.ts index 51008b00d24..cccfee273b8 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensions.contribution.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensions.contribution.ts @@ -207,7 +207,7 @@ Registry.as(ConfigurationExtensions.Configuration) description: localize('extensionsAutoUpdate', "Automatically update extensions."), default: true, scope: ConfigurationScope.APPLICATION, - tags: ['backgroundOnlineFeature'] + tags: ['usesOnlineServices'] }, 'extensions.ignoreRecommendations': { type: 'boolean', @@ -218,7 +218,7 @@ Registry.as(ConfigurationExtensions.Configuration) type: 'boolean', description: localize('extensionsShowRecommendationsOnlyOnDemand', "When enabled, recommendations will not be fetched or shown unless specifically requested by the user."), default: false, - tags: ['backgroundOnlineFeature'] + tags: ['usesOnlineServices'] }, 'extensions.closeExtensionDetailsOnViewChange': { type: 'boolean', diff --git a/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts b/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts index 6f6406e04b0..fa7fc7390ca 100644 --- a/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts +++ b/src/vs/workbench/parts/preferences/browser/settingsEditor2.ts @@ -32,7 +32,7 @@ import { BaseEditor } from 'vs/workbench/browser/parts/editor/baseEditor'; import { EditorOptions, IEditor } from 'vs/workbench/common/editor'; import { SearchWidget, SettingsTarget, SettingsTargetsWidget } from 'vs/workbench/parts/preferences/browser/preferencesWidgets'; import { commonlyUsedData, tocData } from 'vs/workbench/parts/preferences/browser/settingsLayout'; -import { ISettingsEditorViewState, resolveExtensionsSettings, resolveSettingsTree, SearchResultIdx, SearchResultModel, SettingsRenderer, SettingsTree, SettingsTreeElement, SettingsTreeFilter, SettingsTreeGroupElement, SettingsTreeModel, SettingsTreeSettingElement, MODIFIED_SETTING_TAG, BACKGROUND_ONLINE_TAG } from 'vs/workbench/parts/preferences/browser/settingsTree'; +import { ISettingsEditorViewState, resolveExtensionsSettings, resolveSettingsTree, SearchResultIdx, SearchResultModel, SettingsRenderer, SettingsTree, SettingsTreeElement, SettingsTreeFilter, SettingsTreeGroupElement, SettingsTreeModel, SettingsTreeSettingElement, MODIFIED_SETTING_TAG, ONLINE_SERVICES_SETTING_TAG } from 'vs/workbench/parts/preferences/browser/settingsTree'; import { TOCDataSource, TOCRenderer, TOCTreeModel } from 'vs/workbench/parts/preferences/browser/tocTree'; import { CONTEXT_SETTINGS_EDITOR, CONTEXT_SETTINGS_FIRST_ROW_FOCUS, CONTEXT_SETTINGS_ROW_FOCUS, CONTEXT_SETTINGS_SEARCH_FOCUS, CONTEXT_TOC_ROW_FOCUS, IPreferencesSearchService, ISearchProvider } from 'vs/workbench/parts/preferences/common/preferences'; import { IPreferencesService, ISearchResult, ISettingsEditorModel } from 'vs/workbench/services/preferences/common/preferences'; @@ -236,8 +236,8 @@ export class SettingsEditor2 extends BaseEditor { this), this.instantiationService.createInstance( FilterByTagAction, - localize('filterBackgroundOnlineLabel', "Control background online features"), - BACKGROUND_ONLINE_TAG, + localize('filterOnlineServicesLabel', "Show settings for online services"), + ONLINE_SERVICES_SETTING_TAG, this), new Separator(), this.instantiationService.createInstance(OpenSettingsAction) diff --git a/src/vs/workbench/parts/preferences/browser/settingsTree.ts b/src/vs/workbench/parts/preferences/browser/settingsTree.ts index 282ed7f0c7e..bca419d84bc 100644 --- a/src/vs/workbench/parts/preferences/browser/settingsTree.ts +++ b/src/vs/workbench/parts/preferences/browser/settingsTree.ts @@ -41,7 +41,7 @@ import { ISearchResult, ISetting, ISettingsGroup } from 'vs/workbench/services/p const $ = DOM.$; export const MODIFIED_SETTING_TAG = 'modified'; -export const BACKGROUND_ONLINE_TAG = 'backgroundOnlineFeature'; +export const ONLINE_SERVICES_SETTING_TAG = 'usesOnlineServices'; export abstract class SettingsTreeElement { id: string; diff --git a/src/vs/workbench/services/crashReporter/electron-browser/crashReporterService.ts b/src/vs/workbench/services/crashReporter/electron-browser/crashReporterService.ts index b0997699777..6df2345bd64 100644 --- a/src/vs/workbench/services/crashReporter/electron-browser/crashReporterService.ts +++ b/src/vs/workbench/services/crashReporter/electron-browser/crashReporterService.ts @@ -38,7 +38,7 @@ configurationRegistry.registerConfiguration({ 'type': 'boolean', 'description': nls.localize('telemetry.enableCrashReporting', "Enable crash reports to be sent to Microsoft.\nThis option requires restart to take effect."), 'default': true, - 'tags': ['backgroundOnlineFeature'] + 'tags': ['usesOnlineServices'] } } }); -- GitLab