From 9ce155f3f2e79bf1da3f177391e254b22cec2835 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Thu, 22 Feb 2018 19:08:58 +0100 Subject: [PATCH] notifications - fix border shadow --- .../parts/notifications/media/notificationsToasts.css | 1 - .../browser/parts/notifications/notificationsToasts.ts | 7 ++++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/browser/parts/notifications/media/notificationsToasts.css b/src/vs/workbench/browser/parts/notifications/media/notificationsToasts.css index dd98c205f31..935f3c4c82e 100644 --- a/src/vs/workbench/browser/parts/notifications/media/notificationsToasts.css +++ b/src/vs/workbench/browser/parts/notifications/media/notificationsToasts.css @@ -27,7 +27,6 @@ .monaco-workbench > .notifications-toasts .notification-toast-container > .notification-toast { margin: 5px; /* enables separation and drop shadows around toasts */ - transform: translateY(100%); /* move the notification 50px to the bottom (to prevent bleed through) */ opacity: 0; /* fade the toast in */ transition: transform 300ms ease-out, opacity 300ms ease-out; diff --git a/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts b/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts index 8f625334f81..a774e3c7ad1 100644 --- a/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts +++ b/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts @@ -28,6 +28,7 @@ import { ILifecycleService, LifecyclePhase } from 'vs/platform/lifecycle/common/ interface INotificationToast { list: NotificationsList; container: HTMLElement; + toast: HTMLElement; disposeables: IDisposable[]; } @@ -119,7 +120,7 @@ export class NotificationsToasts extends Themable { verticalScrollMode: ScrollbarVisibility.Hidden }); itemDisposeables.push(notificationList); - this.mapNotificationToToast.set(item, { list: notificationList, container: notificationToastContainer, disposeables: itemDisposeables }); + this.mapNotificationToToast.set(item, { list: notificationList, container: notificationToastContainer, toast: notificationToast, disposeables: itemDisposeables }); // Make visible notificationList.show(); @@ -312,9 +313,9 @@ export class NotificationsToasts extends Themable { } protected updateStyles(): void { - this.mapNotificationToToast.forEach(toast => { + this.mapNotificationToToast.forEach(t => { const widgetShadowColor = this.getColor(widgetShadow); - toast.container.style.boxShadow = widgetShadowColor ? `0 0px 8px ${widgetShadowColor}` : null; + t.toast.style.boxShadow = widgetShadowColor ? `0 0px 8px ${widgetShadowColor}` : null; }); } -- GitLab