提交 9a2696d3 编写于 作者: D Daniel Imms

Don't fire onDidChangeTerminalDimensions when cols/rows is 0

Fixes #83778
上级 c80b8a33
...@@ -460,10 +460,6 @@ import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert'; ...@@ -460,10 +460,6 @@ import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert';
} }
term.show(); term.show();
disposables.push(window.onDidChangeTerminalDimensions(e => { disposables.push(window.onDidChangeTerminalDimensions(e => {
if (e.dimensions.columns === 0 || e.dimensions.rows === 0) {
// HACK: Ignore the event if dimension(s) are zero (#83778)
return;
}
// The default pty dimensions have a chance to appear here since override // The default pty dimensions have a chance to appear here since override
// dimensions happens after the terminal is created. If so just ignore and // dimensions happens after the terminal is created. If so just ignore and
// wait for the right dimensions // wait for the right dimensions
......
...@@ -175,6 +175,9 @@ export class ExtHostTerminal extends BaseExtHostTerminal implements vscode.Termi ...@@ -175,6 +175,9 @@ export class ExtHostTerminal extends BaseExtHostTerminal implements vscode.Termi
// Nothing changed // Nothing changed
return false; return false;
} }
if (cols === 0 || rows === 0) {
return false;
}
this._cols = cols; this._cols = cols;
this._rows = rows; this._rows = rows;
return true; return true;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册