From 98395bd1f532dba03a02026bf2c840a47636bfb6 Mon Sep 17 00:00:00 2001
From: Johannes Rieken <johannes.rieken@gmail.com>
Date: Fri, 28 Sep 2018 10:34:52 +0200
Subject: [PATCH] make sure to always prevent default when clicking links

---
 src/vs/base/browser/htmlContentRenderer.ts | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/vs/base/browser/htmlContentRenderer.ts b/src/vs/base/browser/htmlContentRenderer.ts
index c74a313b467..0fc79f69b09 100644
--- a/src/vs/base/browser/htmlContentRenderer.ts
+++ b/src/vs/base/browser/htmlContentRenderer.ts
@@ -12,6 +12,7 @@ import { removeMarkdownEscapes, IMarkdownString } from 'vs/base/common/htmlConte
 import * as marked from 'vs/base/common/marked/marked';
 import { IMouseEvent } from 'vs/base/browser/mouseEvent';
 import { IDisposable } from 'vs/base/common/lifecycle';
+import { onUnexpectedError } from 'vs/base/common/errors';
 
 export interface IContentActionHandler {
 	callback: (content: string, event?: IMouseEvent) => void;
@@ -152,12 +153,16 @@ export function renderMarkdown(markdown: IMarkdownString, options: RenderOptions
 					return;
 				}
 			}
-
-			const href = target.dataset['href'];
-			if (href) {
-				options.actionHandler.callback(href, event);
+			try {
+				const href = target.dataset['href'];
+				if (href) {
+					options.actionHandler.callback(href, event);
+				}
+			} catch (err) {
+				onUnexpectedError(err);
+			} finally {
+				event.preventDefault();
 			}
-			event.preventDefault();
 		}));
 	}
 
-- 
GitLab