Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
95101bf3
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
95101bf3
编写于
4月 06, 2018
作者:
B
Benjamin Pasero
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Revert "SelectBox: Add bounds checking on selected option. Addresses: #43475, #44309 (#47044)"
This reverts commit
043538ee
.
上级
356c4bab
变更
2
显示空白变更内容
内联
并排
Showing
2 changed file
with
2 addition
and
28 deletion
+2
-28
src/vs/base/browser/ui/selectBox/selectBoxCustom.ts
src/vs/base/browser/ui/selectBox/selectBoxCustom.ts
+1
-17
src/vs/base/browser/ui/selectBox/selectBoxNative.ts
src/vs/base/browser/ui/selectBox/selectBoxNative.ts
+1
-11
未找到文件。
src/vs/base/browser/ui/selectBox/selectBoxCustom.ts
浏览文件 @
95101bf3
...
...
@@ -229,17 +229,7 @@ export class SelectBoxList implements ISelectBoxDelegate, IDelegate<ISelectOptio
}
if
(
selected
!==
undefined
)
{
// Guard against out of bounds selected values
// Cannot currently return error, set selected within range
if
(
selected
>=
0
&&
selected
<
this
.
options
.
length
)
{
this
.
select
(
selected
);
}
else
if
(
selected
>
this
.
options
.
length
-
1
)
{
// This could make client out of sync with the select
this
.
select
(
this
.
options
.
length
-
1
);
console
.
error
(
'
selectBoxCustom: setOptions selected exceeds options length
'
);
}
else
if
(
selected
<
0
)
{
this
.
selected
=
0
;
}
}
}
...
...
@@ -363,12 +353,6 @@ export class SelectBoxList implements ISelectBoxDelegate, IDelegate<ISelectOptio
return
;
}
// Bounds check selected/list before attempting to show
if
(
this
.
selected
<
0
||
this
.
selected
>
this
.
options
.
length
-
1
||
!
this
.
selectList
.
length
)
{
console
.
error
(
'
selectBoxCustom: showSelectDropDown this.select exceeds options length or empty list
'
);
return
;
}
this
.
_isVisible
=
true
;
this
.
cloneElementFont
(
this
.
selectElement
,
this
.
selectDropDownContainer
);
this
.
contextViewProvider
.
showContextView
({
...
...
src/vs/base/browser/ui/selectBox/selectBoxNative.ts
浏览文件 @
95101bf3
...
...
@@ -84,17 +84,7 @@ export class SelectBoxNative implements ISelectBoxDelegate {
}
if
(
selected
!==
undefined
)
{
// Guard against out of bounds selected values
// Cannot currently return error, set selected within range
if
(
selected
>=
0
&&
selected
<
this
.
options
.
length
)
{
this
.
select
(
selected
);
}
else
if
(
selected
>
this
.
options
.
length
-
1
)
{
// This could make client out of sync with the select
this
.
select
(
this
.
options
.
length
-
1
);
console
.
error
(
'
selectBoxNative: setOptions selected exceeds options length
'
);
}
else
if
(
selected
<
0
)
{
this
.
selected
=
0
;
}
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录