From 8f2523c4b12efa371ff16b0acc77099f378bc7d2 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Fri, 16 Jun 2017 07:52:32 +0200 Subject: [PATCH] fix potential npe in editor.hide() --- .../workbench/browser/parts/editor/editorGroupsControl.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/browser/parts/editor/editorGroupsControl.ts b/src/vs/workbench/browser/parts/editor/editorGroupsControl.ts index 4bc4a3b143a..2f9f4224462 100644 --- a/src/vs/workbench/browser/parts/editor/editorGroupsControl.ts +++ b/src/vs/workbench/browser/parts/editor/editorGroupsControl.ts @@ -519,8 +519,12 @@ export class EditorGroupsControl extends Themable implements IEditorGroupsContro // Clear Position this.clearPosition(position); - // Take editor container offdom and hide - editor.getContainer().offDOM().hide(); + // Take editor container offdom and hide. Check if the editor container + // exists in case someone manages to hide an editor before it was created + const editorContainer = editor.getContainer(); + if (editorContainer) { + editorContainer.offDOM().hide(); + } // Adjust layout and rochade if instructed to do so if (layoutAndRochade) { -- GitLab