From 8bf066e3dca775522bdebde4f742e71498b09bca Mon Sep 17 00:00:00 2001 From: Rob Lourens Date: Wed, 23 May 2018 17:41:18 -0700 Subject: [PATCH] Fix #50335 --- .../search/test/common/searchModel.test.ts | 31 +++++++++---------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/vs/workbench/parts/search/test/common/searchModel.test.ts b/src/vs/workbench/parts/search/test/common/searchModel.test.ts index f8690874c6d..ae9d4349c90 100644 --- a/src/vs/workbench/parts/search/test/common/searchModel.test.ts +++ b/src/vs/workbench/parts/search/test/common/searchModel.test.ts @@ -125,25 +125,24 @@ suite('SearchModel', () => { assert.deepEqual(['searchResultsFirstRender', { duration: -1 }], data); }); - // test('Search Model: Search reports timed telemetry on search when progress is not called', () => { - // let target2 = sinon.spy(); - // stub(nullEvent, 'stop', target2); - // let target1 = sinon.stub().returns(nullEvent); - // instantiationService.stub(ITelemetryService, 'publicLog', target1); - - // instantiationService.stub(ISearchService, 'search', ppromiseWithProgress([])); + test('Search Model: Search reports timed telemetry on search when progress is not called', () => { + let target2 = sinon.spy(); + stub(nullEvent, 'stop', target2); + let target1 = sinon.stub().returns(nullEvent); + instantiationService.stub(ITelemetryService, 'publicLog', target1); - // let testObject = instantiationService.createInstance(SearchModel); - // const result = testObject.search({ contentPattern: { pattern: 'somestring' }, type: 1, folderQueries }); + instantiationService.stub(ISearchService, 'search', ppromiseWithProgress([])); - // return timeout(1).then(() => { - // return result.then(() => { - // assert.ok(target1.calledWith('searchResultsFirstRender')); - // assert.ok(target1.calledWith('searchResultsFinished')); - // }); + let testObject = instantiationService.createInstance(SearchModel); + const result = testObject.search({ contentPattern: { pattern: 'somestring' }, type: 1, folderQueries }); - // }); - // }); + return result.then(() => { + return timeout(1).then(() => { + assert.ok(target1.calledWith('searchResultsFirstRender')); + assert.ok(target1.calledWith('searchResultsFinished')); + }); + }); + }); test('Search Model: Search reports timed telemetry on search when progress is called', () => { let target2 = sinon.spy(); -- GitLab