From 8b6daa690b7b76cc9f9c4760038a3d8433e0d91f Mon Sep 17 00:00:00 2001 From: Rachel Macfarlane Date: Mon, 25 Feb 2019 15:56:08 -0800 Subject: [PATCH] Fix includeExtensions checkbox value in issue reporter --- src/vs/code/electron-browser/issue/issueReporterMain.ts | 4 ++-- src/vs/code/electron-browser/issue/issueReporterModel.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/vs/code/electron-browser/issue/issueReporterMain.ts b/src/vs/code/electron-browser/issue/issueReporterMain.ts index c11db627282..ca5ed69d0af 100644 --- a/src/vs/code/electron-browser/issue/issueReporterMain.ts +++ b/src/vs/code/electron-browser/issue/issueReporterMain.ts @@ -346,7 +346,7 @@ export class IssueReporter extends Disposable { const value = (e.target).value; const problemSourceHelpText = this.getElementById('problem-source-help-text')!; if (value === '') { - this.issueReporterModel.update({ fileOnExtension: undefined, includeExtensions: false }); + this.issueReporterModel.update({ fileOnExtension: undefined }); show(problemSourceHelpText); this.clearSearchResults(); this.render(); @@ -356,7 +356,7 @@ export class IssueReporter extends Disposable { } const fileOnExtension = JSON.parse(value); - this.issueReporterModel.update({ fileOnExtension: fileOnExtension, includeExtensions: !fileOnExtension }); + this.issueReporterModel.update({ fileOnExtension: fileOnExtension }); this.render(); const title = (this.getElementById('issue-title')).value; diff --git a/src/vs/code/electron-browser/issue/issueReporterModel.ts b/src/vs/code/electron-browser/issue/issueReporterModel.ts index b9625ea066f..b918ceff961 100644 --- a/src/vs/code/electron-browser/issue/issueReporterModel.ts +++ b/src/vs/code/electron-browser/issue/issueReporterModel.ts @@ -121,7 +121,7 @@ ${this.getInfos()} } if (this._data.issueType === IssueType.Bug || this._data.issueType === IssueType.PerformanceIssue) { - if (this._data.includeExtensions) { + if (!this._data.fileOnExtension && this._data.includeExtensions) { info += this.generateExtensionsMd(); } } -- GitLab