From 8786a903f0ab92a4dc6640ff511ab28fc53f6a03 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Tue, 16 May 2017 11:58:42 -0700 Subject: [PATCH] use Switch instead of map for looking up modes --- .../src/features/bufferSyncSupport.ts | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/extensions/typescript/src/features/bufferSyncSupport.ts b/extensions/typescript/src/features/bufferSyncSupport.ts index 2c1b414723d..f0928f2c127 100644 --- a/extensions/typescript/src/features/bufferSyncSupport.ts +++ b/extensions/typescript/src/features/bufferSyncSupport.ts @@ -19,12 +19,15 @@ interface IDiagnosticRequestor { requestDiagnostic(filepath: string): void; } -const Mode2ScriptKind: ObjectMap<'TS' | 'JS' | 'TSX' | 'JSX'> = { - 'typescript': 'TS', - 'typescriptreact': 'TSX', - 'javascript': 'JS', - 'javascriptreact': 'JSX' -}; +function mode2ScriptKind(mode: string): 'TS' | 'TSX' | 'JS' | 'JSX' | undefined { + switch (mode) { + case 'typescript': return 'TS'; + case 'typescriptreact': return 'TSX'; + case 'javascript': return 'JS'; + case 'javascriptreact': return 'JSX'; + } + return undefined; +} class SyncedBuffer { @@ -42,7 +45,7 @@ class SyncedBuffer { }; if (this.client.apiVersion.has203Features()) { - const scriptKind = Mode2ScriptKind[this.document.languageId]; + const scriptKind = mode2ScriptKind(this.document.languageId); if (scriptKind) { args.scriptKindName = scriptKind; } @@ -104,8 +107,6 @@ export default class BufferSyncSupport { private disposables: Disposable[] = []; private syncedBuffers: ObjectMap; - private projectValidationRequested: boolean; - private pendingDiagnostics: { [key: string]: number; }; private diagnosticDelayer: Delayer; private checkGlobalTSCVersion: boolean; @@ -117,8 +118,6 @@ export default class BufferSyncSupport { this.diagnostics = diagnostics; this._validate = validate; - this.projectValidationRequested = false; - this.pendingDiagnostics = Object.create(null); this.diagnosticDelayer = new Delayer(300); -- GitLab