From 86c05da801cc99d5be9a52f116cad3149d743446 Mon Sep 17 00:00:00 2001 From: Rachel Macfarlane Date: Mon, 2 Jul 2018 14:01:13 -0700 Subject: [PATCH] Fixes #51521, TypeError: Cannot read property 'close' of undefined --- src/vs/platform/issue/electron-main/issueService.ts | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/vs/platform/issue/electron-main/issueService.ts b/src/vs/platform/issue/electron-main/issueService.ts index 05a43fe1992..cebb4e61237 100644 --- a/src/vs/platform/issue/electron-main/issueService.ts +++ b/src/vs/platform/issue/electron-main/issueService.ts @@ -78,8 +78,10 @@ export class IssueService implements IIssueService { this._issueWindow.on('close', () => this._issueWindow = null); this._issueParentWindow.on('closed', () => { - this._issueWindow.close(); - this._issueWindow = null; + if (this._issueWindow) { + this._issueWindow.close(); + this._issueWindow = null; + } }); } @@ -139,8 +141,10 @@ export class IssueService implements IIssueService { this._processExplorerWindow.on('close', () => this._processExplorerWindow = void 0); parentWindow.on('close', () => { - this._processExplorerWindow.close(); - this._processExplorerWindow = null; + if (this._processExplorerWindow) { + this._processExplorerWindow.close(); + this._processExplorerWindow = null; + } }); } -- GitLab