From 73f25869d1f41c6738ac2b7c16a37c8f079109c7 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Tue, 9 Jun 2020 12:27:25 +0200 Subject: [PATCH] Show error for '/' in Windows simple file dialog Fixes #2448 --- src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts b/src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts index e159b9591ed..26350c27196 100644 --- a/src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts +++ b/src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts @@ -765,6 +765,9 @@ export class SimpleFileDialog { // File or folder doesn't exist this.filePickBox.validationMessage = nls.localize('remoteFileDialog.validateNonexistentDir', 'Please enter a path that exists.'); return Promise.resolve(false); + } else if (uri.path === '/' && (await this.isWindowsOS())) { + this.filePickBox.validationMessage = nls.localize('remoteFileDialog.windowsDriveLetter', 'Please start the path with a drive letter.'); + return Promise.resolve(false); } else if (stat.isDirectory && !this.allowFolderSelection) { // Folder selected when folder selection not permitted this.filePickBox.validationMessage = nls.localize('remoteFileDialog.validateFileOnly', 'Please select a file.'); -- GitLab