From 7279524b97c5dba02530c4fa9db1cc18334fb920 Mon Sep 17 00:00:00 2001 From: isidor Date: Wed, 25 Mar 2020 12:35:15 +0100 Subject: [PATCH] Accessibility: Mark document-like outputs with role="document" for easier screen reader navigation. fixes #93087 --- src/vs/workbench/contrib/extensions/browser/extensionEditor.ts | 1 + .../contrib/welcome/page/browser/vs_code_welcome_page.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts b/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts index ef82fc250c8..7bd241744db 100644 --- a/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts +++ b/src/vs/workbench/contrib/extensions/browser/extensionEditor.ts @@ -206,6 +206,7 @@ export class ExtensionEditor extends BaseEditor { const root = append(parent, $('.extension-editor')); root.tabIndex = 0; // this is required for the focus tracker on the editor root.style.outline = 'none'; + root.setAttribute('role', 'document'); const header = append(root, $('.header')); const iconContainer = append(header, $('.icon-container')); diff --git a/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts b/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts index ab2af19a26a..30f321498e8 100644 --- a/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts +++ b/src/vs/workbench/contrib/welcome/page/browser/vs_code_welcome_page.ts @@ -8,7 +8,7 @@ import { localize } from 'vs/nls'; export default () => `
-
+

${escape(localize('welcomePage.vscode', "Visual Studio Code"))}

${escape(localize({ key: 'welcomePage.editingEvolved', comment: ['Shown as subtitle on the Welcome page.'] }, "Editing evolved"))}

-- GitLab