diff --git a/src/vs/platform/configuration/common/configurationRegistry.ts b/src/vs/platform/configuration/common/configurationRegistry.ts index 7708e9a7e54ea49625b0b0978d8a06c788f04cda..d2495cce311a89cc3f9dba69a0f7f4edb4037efb 100644 --- a/src/vs/platform/configuration/common/configurationRegistry.ts +++ b/src/vs/platform/configuration/common/configurationRegistry.ts @@ -53,7 +53,7 @@ export interface IConfigurationRegistry { } export enum ConfigurationScope { - WORKBENCH = 1, + WINDOW = 1, RESOURCE } @@ -158,7 +158,7 @@ class ConfigurationRegistry implements IConfigurationRegistry { } } - private validateAndRegisterProperties(configuration: IConfigurationNode, validate: boolean = true, scope: ConfigurationScope = ConfigurationScope.WORKBENCH, overridable: boolean = false) { + private validateAndRegisterProperties(configuration: IConfigurationNode, validate: boolean = true, scope: ConfigurationScope = ConfigurationScope.WINDOW, overridable: boolean = false) { scope = configuration.scope !== void 0 && configuration.scope !== null ? configuration.scope : scope; overridable = configuration.overridable || overridable; let properties = configuration.properties; diff --git a/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts b/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts index 26098d9bf673c0021c579f52e5cec705ad9de7aa..c546e80e0af4fb523857d1c1b1ba463b6e15cebe 100644 --- a/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts +++ b/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts @@ -1003,7 +1003,7 @@ class UnsupportedWorkbenchSettingsRenderer extends Disposable { const configurationRegistry = Registry.as(ConfigurationExtensions.Configuration).getConfigurationProperties(); const folderKeys = this.configurationService.keys({ resource: this.workspaceSettingsEditorModel.uri }).folder; - const workbenchKeys = folderKeys.filter(key => configurationRegistry[key] && configurationRegistry[key].scope === ConfigurationScope.WORKBENCH); + const workbenchKeys = folderKeys.filter(key => configurationRegistry[key] && configurationRegistry[key].scope === ConfigurationScope.WINDOW); if (workbenchKeys.length) { const ranges: IRange[] = []; for (const unsupportedKey of workbenchKeys) { diff --git a/src/vs/workbench/parts/preferences/browser/preferencesService.ts b/src/vs/workbench/parts/preferences/browser/preferencesService.ts index e957b4c316430ce3e594f99e26537eef7e3ae1f2..1ac73c1283e054171da95b17f2e2d6d9a1ac83e8 100644 --- a/src/vs/workbench/parts/preferences/browser/preferencesService.ts +++ b/src/vs/workbench/parts/preferences/browser/preferencesService.ts @@ -135,7 +135,7 @@ export class PreferencesService extends Disposable implements IPreferencesServic promise = TPromise.join([this.extensionService.onReady(), this.fetchMostCommonlyUsedSettings()]) .then(result => { const mostCommonSettings = result[1]; - const model = this.instantiationService.createInstance(DefaultSettingsEditorModel, uri, mostCommonSettings, ConfigurationScope.WORKBENCH); + const model = this.instantiationService.createInstance(DefaultSettingsEditorModel, uri, mostCommonSettings, ConfigurationScope.WINDOW); return model; }); this.defaultPreferencesEditorModels.set(uri, promise); diff --git a/src/vs/workbench/parts/preferences/common/preferencesModels.ts b/src/vs/workbench/parts/preferences/common/preferencesModels.ts index 4cc3705f767f57965af6b08ffc8d41a531ddcb28..1f7caecf563b60d34d1d8315bac9debf250abefc 100644 --- a/src/vs/workbench/parts/preferences/common/preferencesModels.ts +++ b/src/vs/workbench/parts/preferences/common/preferencesModels.ts @@ -751,7 +751,7 @@ export class DefaultSettingsEditorModel extends AbstractSettingsModel implements } private matchesScope(property: IConfigurationNode): boolean { - if (this.configurationScope === ConfigurationScope.WORKBENCH) { + if (this.configurationScope === ConfigurationScope.WINDOW) { return true; } return property.scope === this.configurationScope; diff --git a/src/vs/workbench/services/configuration/common/configurationModels.ts b/src/vs/workbench/services/configuration/common/configurationModels.ts index e383cea7ab6bfc09db56ce994eb2257ad78fdea0..9a0226735f8d8ab22b9eb94d3dd987603940fefd 100644 --- a/src/vs/workbench/services/configuration/common/configurationModels.ts +++ b/src/vs/workbench/services/configuration/common/configurationModels.ts @@ -131,7 +131,7 @@ export class FolderSettingsModel extends CustomConfigurationModel { } public createWorkspaceConfigurationModel(): ConfigurationModel { - return this.createScopedConfigurationModel(ConfigurationScope.WORKBENCH); + return this.createScopedConfigurationModel(ConfigurationScope.WINDOW); } public createFolderScopedConfigurationModel(): ConfigurationModel { @@ -153,7 +153,7 @@ export class FolderSettingsModel extends CustomConfigurationModel { private getScope(key: string, configurationProperties: { [qualifiedKey: string]: IConfigurationPropertySchema }): ConfigurationScope { const propertySchema = configurationProperties[key]; - return propertySchema ? propertySchema.scope : ConfigurationScope.WORKBENCH; + return propertySchema ? propertySchema.scope : ConfigurationScope.WINDOW; } } @@ -168,7 +168,7 @@ export class FolderConfigurationModel extends CustomConfigurationModel { this._contents = {}; this._overrides = []; - this.doMerge(this, ConfigurationScope.WORKBENCH === this.scope ? this.workspaceSettingsConfig : this.workspaceSettingsConfig.createFolderScopedConfigurationModel()); + this.doMerge(this, ConfigurationScope.WINDOW === this.scope ? this.workspaceSettingsConfig : this.workspaceSettingsConfig.createFolderScopedConfigurationModel()); for (const configModel of this.scopedConfigs) { this.doMerge(this, configModel); } diff --git a/src/vs/workbench/services/configuration/node/configuration.ts b/src/vs/workbench/services/configuration/node/configuration.ts index 2b02cef9c2297acff84e7f6f76e015d6514a95ff..1c91eab0b74c4a6243d7152ffc1d7b32f5508369 100644 --- a/src/vs/workbench/services/configuration/node/configuration.ts +++ b/src/vs/workbench/services/configuration/node/configuration.ts @@ -79,13 +79,13 @@ const configurationExtPoint = ExtensionsRegistry.registerExtensionPoint(new FolderSettingsModel(null), [], ConfigurationScope.RESOURCE), false); } } diff --git a/src/vs/workbench/services/configuration/test/common/configurationModels.test.ts b/src/vs/workbench/services/configuration/test/common/configurationModels.test.ts index 321bc7efc06d1c7ef3b206e5fb2a92defbe1b91b..a6755918258a36073e27285dca05afc75759376a 100644 --- a/src/vs/workbench/services/configuration/test/common/configurationModels.test.ts +++ b/src/vs/workbench/services/configuration/test/common/configurationModels.test.ts @@ -15,7 +15,7 @@ suite('ConfigurationService - Model', () => { awesome: true })); - const testObject = new FolderConfigurationModel(settingsConfig, [], ConfigurationScope.WORKBENCH); + const testObject = new FolderConfigurationModel(settingsConfig, [], ConfigurationScope.WINDOW); assert.equal(testObject.getContentsFor('task'), undefined); }); @@ -36,7 +36,7 @@ suite('ConfigurationService - Model', () => { } }; - assert.deepEqual(new FolderConfigurationModel(settingsConfig, [tasksConfig], ConfigurationScope.WORKBENCH).contents, expected); + assert.deepEqual(new FolderConfigurationModel(settingsConfig, [tasksConfig], ConfigurationScope.WINDOW).contents, expected); }); test('Test consolidate (settings and launch)', () => { @@ -55,7 +55,7 @@ suite('ConfigurationService - Model', () => { } }; - assert.deepEqual(new FolderConfigurationModel(settingsConfig, [launchConfig], ConfigurationScope.WORKBENCH).contents, expected); + assert.deepEqual(new FolderConfigurationModel(settingsConfig, [launchConfig], ConfigurationScope.WINDOW).contents, expected); }); test('Test consolidate (settings and launch and tasks) - launch/tasks wins over settings file', () => { @@ -91,7 +91,7 @@ suite('ConfigurationService - Model', () => { } }; - assert.deepEqual(new FolderConfigurationModel(settingsConfig, [launchConfig, tasksConfig], ConfigurationScope.WORKBENCH).contents, expected); - assert.deepEqual(new FolderConfigurationModel(settingsConfig, [tasksConfig, launchConfig], ConfigurationScope.WORKBENCH).contents, expected); + assert.deepEqual(new FolderConfigurationModel(settingsConfig, [launchConfig, tasksConfig], ConfigurationScope.WINDOW).contents, expected); + assert.deepEqual(new FolderConfigurationModel(settingsConfig, [tasksConfig, launchConfig], ConfigurationScope.WINDOW).contents, expected); }); }); \ No newline at end of file