From 6e92e3aca1d56bdeef914c77f4255be088ffd277 Mon Sep 17 00:00:00 2001 From: Joao Moreno Date: Thu, 1 Nov 2018 15:14:30 +0100 Subject: [PATCH] Revert "cache panel body size" This reverts commit febf978c2834da84531dfc3759988845c15ef758. fixes #61450 --- src/vs/base/browser/ui/splitview/panelview.ts | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/vs/base/browser/ui/splitview/panelview.ts b/src/vs/base/browser/ui/splitview/panelview.ts index 8ce998140a0..2aa77865f06 100644 --- a/src/vs/base/browser/ui/splitview/panelview.ts +++ b/src/vs/base/browser/ui/splitview/panelview.ts @@ -46,6 +46,7 @@ export abstract class Panel implements IView { protected _expanded: boolean; protected disposables: IDisposable[] = []; + private expandedSize: number | undefined = undefined; private _headerVisible = true; private _minimumBodySize: number; private _maximumBodySize: number; @@ -54,9 +55,6 @@ export abstract class Panel implements IView { private header: HTMLElement; - private cachedExpandedSize: number | undefined = undefined; - private cachedBodySize: number | undefined = undefined; - private _onDidChange = new Emitter(); readonly onDidChange: Event = this._onDidChange.event; @@ -131,7 +129,7 @@ export abstract class Panel implements IView { this._expanded = !!expanded; this.updateHeader(); - this._onDidChange.fire(expanded ? this.cachedExpandedSize : undefined); + this._onDidChange.fire(expanded ? this.expandedSize : undefined); } get headerVisible(): boolean { @@ -192,14 +190,8 @@ export abstract class Panel implements IView { const headerSize = this.headerVisible ? Panel.HEADER_SIZE : 0; if (this.isExpanded()) { - const bodySize = size - headerSize; - - if (bodySize !== this.cachedBodySize) { - this.layoutBody(bodySize); - this.cachedBodySize = bodySize; - } - - this.cachedExpandedSize = size; + this.layoutBody(size - headerSize); + this.expandedSize = size; } } -- GitLab