From 6e5a73c6ce5c729a965f803870dd9e924a6ec28f Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Tue, 14 Apr 2020 17:25:24 +0200 Subject: [PATCH] actually fix #94775 --- src/vs/base/parts/quickinput/browser/quickInput.ts | 2 +- src/vs/base/parts/quickinput/browser/quickInputList.ts | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/vs/base/parts/quickinput/browser/quickInput.ts b/src/vs/base/parts/quickinput/browser/quickInput.ts index e6c6676aae2..3d86c58d73e 100644 --- a/src/vs/base/parts/quickinput/browser/quickInput.ts +++ b/src/vs/base/parts/quickinput/browser/quickInput.ts @@ -662,7 +662,7 @@ class QuickPick extends QuickInput implements IQuickPi this.ui.list.clearFocus(); } })); - this.visibleDisposables.add(this.ui.inputBox.onKeyDown(event => { + this.visibleDisposables.add((this._hideInput ? this.ui.list : this.ui.inputBox).onKeyDown((event: KeyboardEvent | StandardKeyboardEvent) => { switch (event.keyCode) { case KeyCode.DownArrow: this.ui.list.focus(QuickInputListFocus.Next); diff --git a/src/vs/base/parts/quickinput/browser/quickInputList.ts b/src/vs/base/parts/quickinput/browser/quickInputList.ts index a6c3a99c82b..4b4cf3ca416 100644 --- a/src/vs/base/parts/quickinput/browser/quickInputList.ts +++ b/src/vs/base/parts/quickinput/browser/quickInputList.ts @@ -263,6 +263,8 @@ export class QuickInputList { onChangedCheckedElements: Event = this._onChangedCheckedElements.event; private readonly _onButtonTriggered = new Emitter>(); onButtonTriggered = this._onButtonTriggered.event; + private readonly _onKeyDown = new Emitter(); + onKeyDown: Event = this._onKeyDown.event; private readonly _onLeave = new Emitter(); onLeave: Event = this._onLeave.event; private _fireCheckedEvents = true; @@ -313,6 +315,8 @@ export class QuickInputList { } break; } + + this._onKeyDown.fire(event); })); this.disposables.push(this.list.onMouseDown(e => { if (e.browserEvent.button !== 2) { @@ -347,6 +351,7 @@ export class QuickInputList { this._onChangedCheckedElements, this._onButtonTriggered, this._onLeave, + this._onKeyDown ); } -- GitLab