From 69fe34632fa4651e89db040fb205f0c739598197 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Fri, 21 Oct 2016 11:43:24 +0200 Subject: [PATCH] fire quick fix compute event when model changed, fixes #14141 --- src/vs/editor/contrib/quickFix/browser/quickFix.ts | 4 ++-- src/vs/editor/contrib/quickFix/browser/quickFixModel.ts | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/vs/editor/contrib/quickFix/browser/quickFix.ts b/src/vs/editor/contrib/quickFix/browser/quickFix.ts index bc4b45960af..124e1fa30fa 100644 --- a/src/vs/editor/contrib/quickFix/browser/quickFix.ts +++ b/src/vs/editor/contrib/quickFix/browser/quickFix.ts @@ -62,10 +62,10 @@ export class QuickFixController implements IEditorContribution { } private _onQuickFixEvent(e: QuickFixComputeEvent): void { - if (e.type === 'manual') { + if (e && e.type === 'manual') { this._quickFixContextMenu.show(e.fixes, e.position); - } else if (e.fixes) { + } else if (e && e.fixes) { // auto magically triggered // * update an existing list of code actions // * manage light bulb diff --git a/src/vs/editor/contrib/quickFix/browser/quickFixModel.ts b/src/vs/editor/contrib/quickFix/browser/quickFixModel.ts index 19bd1d66e3e..ee282098c29 100644 --- a/src/vs/editor/contrib/quickFix/browser/quickFixModel.ts +++ b/src/vs/editor/contrib/quickFix/browser/quickFixModel.ts @@ -137,6 +137,10 @@ export class QuickFixModel { && !this._editor.getConfiguration().readOnly) { this._quickFixOracle = new QuickFixOracle(this._editor, this._markerService, p => this._onDidChangeFixes.fire(p)); + + } else { + // signal unavailable + this._onDidChangeFixes.fire(undefined); } } -- GitLab