From 683b531ca9b4a90c7615275e2fc8bf9be934ecf2 Mon Sep 17 00:00:00 2001
From: Dirk Baeumer <dirkb@microsoft.com>
Date: Fri, 13 Oct 2017 11:38:10 +0200
Subject: [PATCH] Addresses 35734

---
 .../tasks/electron-browser/task.contribution.ts      | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts b/src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts
index 1737491b685..d1dc34a51f8 100644
--- a/src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts
+++ b/src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts
@@ -1421,6 +1421,8 @@ class TaskService extends EventEmitter implements ITaskService {
 						let legacyTaskConfigurations = folderTasks.set ? this.getLegacyTaskConfigurations(folderTasks.set) : undefined;
 						let customTasksToDelete: Task[] = [];
 						if (configurations || legacyTaskConfigurations) {
+							let unUsedConfigurations: Set<string> = new Set<string>();
+							Object.keys(configurations.byIdentifier).forEach(key => unUsedConfigurations.add(key));
 							for (let task of contributed) {
 								if (!ContributedTask.is(task)) {
 									continue;
@@ -1428,6 +1430,7 @@ class TaskService extends EventEmitter implements ITaskService {
 								if (configurations) {
 									let configuringTask = configurations.byIdentifier[task.defines._key];
 									if (configuringTask) {
+										unUsedConfigurations.delete(task.defines._key);
 										result.add(key, TaskConfig.createCustomTask(task, configuringTask));
 									} else {
 										result.add(key, task);
@@ -1458,6 +1461,15 @@ class TaskService extends EventEmitter implements ITaskService {
 							} else {
 								result.add(key, ...folderTasks.set.tasks);
 							}
+							unUsedConfigurations.forEach((value) => {
+								let configuringTask = configurations.byIdentifier[value];
+								this._outputChannel.append(nls.localize(
+									'TaskService.noConfiguration',
+									'Error: No task has been contributed for the following task configuration:\n{0}\nThe task configuration will be ignored.\n',
+									JSON.stringify(configuringTask._source.config.element, undefined, 4)
+								));
+								this.showOutput();
+							});
 						} else {
 							result.add(key, ...folderTasks.set.tasks);
 							result.add(key, ...contributed);
-- 
GitLab