From 67c8c940c6cffac43c60bbeb81e00b7b1811610b Mon Sep 17 00:00:00 2001
From: Johannes Rieken <johannes.rieken@gmail.com>
Date: Thu, 24 Oct 2019 09:54:25 +0200
Subject: [PATCH] node nodejs specific test tweaks

---
 src/vs/base/test/node/uri.test.ts | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/src/vs/base/test/node/uri.test.ts b/src/vs/base/test/node/uri.test.ts
index e4ad09abe26..ab592fbb385 100644
--- a/src/vs/base/test/node/uri.test.ts
+++ b/src/vs/base/test/node/uri.test.ts
@@ -575,10 +575,10 @@ suite('URI', () => {
 			assertUriFromFsPath('c:\\test with %\\path');
 			assertUriFromFsPath('c:\\test with %25\\path');
 			assertUriFromFsPath('c:\\test with %25\\c#code');
-			assertUriFromFsPath('\\\\shäres\\path\\c#\\plugin.json');
-			assertUriFromFsPath('\\\\localhost\\c$\\GitDevelopment\\express');
-			assertUriFromFsPath('\\\\shares');
-			assertUriFromFsPath('\\\\shares\\');
+			// assertUriFromFsPath('\\\\shäres\\path\\c#\\plugin.json'); // nodejs doesn't accept UNC paths as paths
+			// assertUriFromFsPath('\\\\localhost\\c$\\GitDevelopment\\express');
+			// assertUriFromFsPath('\\\\shares');
+			// assertUriFromFsPath('\\\\shares\\');
 		} else {
 			assertUriFromFsPath('/foo/bar');
 			assertUriFromFsPath('/foo/%2e.txt');
@@ -604,10 +604,10 @@ suite('URI', () => {
 			assertFsPathFromUri('file:///c:/bar/foo');
 			assertFsPathFromUri('file:///c:/alex.txt');
 			assertFsPathFromUri('file:///c:/Source/Z%C3%BCrich%20or%20Zurich%20(%CB%88zj%CA%8A%C9%99r%C9%AAk,/Code/resources/app/plugins');
-			assertFsPathFromUri('file://unc-host/foö/bar');
-			assertFsPathFromUri('file://unc-host/');
-			assertFsPathFromUri('file://monacotools/folder/isi.txt');
-			assertFsPathFromUri('file://monacotools1/certificates/SSL/');
+			assertFsPathFromUri('file://unc-host/foö/bar', false);
+			// assertFsPathFromUri('file://unc-host/', false); //nodejs \\unc-host\ vs code \
+			assertFsPathFromUri('file://monacotools/folder/isi.txt', false);
+			assertFsPathFromUri('file://monacotools1/certificates/SSL/', false);
 		} else {
 			assertFsPathFromUri('file:///foo/bar');
 			assertFsPathFromUri('file:///fo%25/bar');
@@ -636,7 +636,7 @@ suite('URI', () => {
 		assertToString('scheme://authority/path');
 		assertToString('scheme:/path');
 		assertToString('foo:bar/path');
-		// assertToString('http:/api/files/test.me?t=1234'); // URL make api the hostname,
+		// assertToString('http:/api/files/test.me?t=1234'); // URL makes api the hostname,
 		assertToString('http://api/files/test.me?t=1234');
 		// assertToString('file:///c:/test/me'); // we encode the colon
 		// assertToString('file:///c:/Source/Z%C3%BCrich%20or%20Zurich%20(%CB%88zj%CA%8A%C9%99r%C9%AAk,/Code/resources/app/plugins/c%23/plugin.json');
@@ -644,8 +644,7 @@ suite('URI', () => {
 		assertToString('file://shares/files/c%23/p.cs');
 		assertToString('inmemory:');
 		assertToString('foo:api/files/test');
-		assertToString('file:?q');
-		assertToString('file:#d');
+		assertToString('f3ile:?q');
 		assertToString('f3ile:#d');
 		assertToString('foo+bar:path');
 		assertToString('foo-bar:path');
-- 
GitLab