From 66eddd98fa38ee1bd66ad8f12ef35e9ff1c7d409 Mon Sep 17 00:00:00 2001 From: t-amqi Date: Mon, 12 Jun 2017 15:52:45 -0700 Subject: [PATCH] Address review changes --- src/vs/code/electron-main/menus.ts | 2 +- src/vs/workbench/parts/quickopen/browser/commandsHandler.ts | 5 +---- .../parts/quickopen/browser/quickopen.contribution.ts | 2 +- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/vs/code/electron-main/menus.ts b/src/vs/code/electron-main/menus.ts index e9cec735992..fe2206f6a36 100644 --- a/src/vs/code/electron-main/menus.ts +++ b/src/vs/code/electron-main/menus.ts @@ -586,7 +586,7 @@ export class CodeMenu { const output = this.createMenuItem(nls.localize({ key: 'miToggleOutput', comment: ['&& denotes a mnemonic'] }, "&&Output"), 'workbench.action.output.toggleOutput'); const debugConsole = this.createMenuItem(nls.localize({ key: 'miToggleDebugConsole', comment: ['&& denotes a mnemonic'] }, "De&&bug Console"), 'workbench.debug.action.toggleRepl'); const integratedTerminal = this.createMenuItem(nls.localize({ key: 'miToggleIntegratedTerminal', comment: ['&& denotes a mnemonic'] }, "&&Integrated Terminal"), 'workbench.action.terminal.toggleTerminal'); - const taskMenu = this.createMenuItem(nls.localize({ key: 'miShowTask', comment: ['&& denotes a mnemonic'] }, "&&Show Tasks..."), 'workbench.action.showTasks'); + const taskMenu = this.createMenuItem(nls.localize({ key: 'miShowTask', comment: ['&& denotes a mnemonic'] }, "Show Tas&&ks..."), 'workbench.action.showTasks'); const problems = this.createMenuItem(nls.localize({ key: 'miMarker', comment: ['&& denotes a mnemonic'] }, "&&Problems"), 'workbench.actions.view.problems'); let additionalViewlets: Electron.MenuItem; diff --git a/src/vs/workbench/parts/quickopen/browser/commandsHandler.ts b/src/vs/workbench/parts/quickopen/browser/commandsHandler.ts index aee3eb1b140..21076a5084e 100644 --- a/src/vs/workbench/parts/quickopen/browser/commandsHandler.ts +++ b/src/vs/workbench/parts/quickopen/browser/commandsHandler.ts @@ -164,10 +164,7 @@ export class ShowTasksAction extends Action { } public run(context?: any): TPromise { - let value = ALL_COMMANDS_PREFIX; - let taskStr = 'tasks'; - value = `${value}${taskStr}`; - + const value = `${ALL_COMMANDS_PREFIX}tasks`; this.quickOpenService.show(value); return TPromise.as(null); diff --git a/src/vs/workbench/parts/quickopen/browser/quickopen.contribution.ts b/src/vs/workbench/parts/quickopen/browser/quickopen.contribution.ts index d70aae56491..e46b5cd8432 100644 --- a/src/vs/workbench/parts/quickopen/browser/quickopen.contribution.ts +++ b/src/vs/workbench/parts/quickopen/browser/quickopen.contribution.ts @@ -41,7 +41,7 @@ registry.registerWorkbenchAction(new SyncActionDescriptor(QuickOpenViewPickerAct }), 'Quick Open View'); registry.registerWorkbenchAction(new SyncActionDescriptor(ShowTasksAction, ShowTasksAction.ID, ShowTasksAction.LABEL, { - primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_T + primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KEY_T }), 'Show Task Menu'); // Register Quick Open Handler -- GitLab