From 66511a0bdb3dcfb40bfdae74108d9da93cd9b6f4 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Thu, 10 Jan 2019 15:16:45 -0800 Subject: [PATCH] Interup geterror during rename Rename is a user triggered operation and should interupt long run error computations --- .../typescript-language-features/src/features/rename.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/extensions/typescript-language-features/src/features/rename.ts b/extensions/typescript-language-features/src/features/rename.ts index 7b1c0ac791e..7112cb91867 100644 --- a/extensions/typescript-language-features/src/features/rename.ts +++ b/extensions/typescript-language-features/src/features/rename.ts @@ -36,8 +36,7 @@ class TypeScriptRenameProvider implements vscode.RenameProvider { if (this.client.apiVersion.gte(API.v310)) { const triggerSpan = renameInfo.triggerSpan; if (triggerSpan) { - const range = typeConverters.Range.fromTextSpan(triggerSpan); - return range; + return typeConverters.Range.fromTextSpan(triggerSpan); } } @@ -90,7 +89,9 @@ class TypeScriptRenameProvider implements vscode.RenameProvider { findInComments: false }; - return this.client.execute('rename', args, token); + return this.client.interuptGetErr(() => { + return this.client.execute('rename', args, token); + }); } private updateLocs( -- GitLab