diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json index 6551b549daa865a7dac14d9da7a8e5af149044a8..297169a7b4b6da92faff2684a6deeb8dfc7a2479 100644 --- a/src/tsconfig.strictNullChecks.json +++ b/src/tsconfig.strictNullChecks.json @@ -527,6 +527,7 @@ "./vs/workbench/browser/actions/toggleStatusbarVisibility.ts", "./vs/workbench/browser/actions/toggleTabsVisibility.ts", "./vs/workbench/browser/actions/toggleZenMode.ts", + "./vs/workbench/browser/actions/workspaceCommands.ts", "./vs/workbench/browser/composite.ts", "./vs/workbench/browser/editor.ts", "./vs/workbench/browser/panel.ts", @@ -608,6 +609,7 @@ "./vs/workbench/parts/extensions/common/extensions.ts", "./vs/workbench/parts/extensions/common/extensionsFileTemplate.ts", "./vs/workbench/parts/extensions/common/extensionsInput.ts", + "./vs/workbench/parts/extensions/electron-browser/extensionsActions.ts", "./vs/workbench/parts/extensions/electron-browser/extensionsActivationProgress.ts", "./vs/workbench/parts/extensions/electron-browser/extensionsUtils.ts", "./vs/workbench/parts/extensions/node/extensionsWorkbenchService.ts", diff --git a/src/vs/workbench/browser/actions/workspaceCommands.ts b/src/vs/workbench/browser/actions/workspaceCommands.ts index 11e873dbb2be679e9b69c63e707d94e71a489669..95c6eba1bcb9084366d3a946ae5ea4111445582a 100644 --- a/src/vs/workbench/browser/actions/workspaceCommands.ts +++ b/src/vs/workbench/browser/actions/workspaceCommands.ts @@ -65,7 +65,7 @@ CommandsRegistry.registerCommand({ canSelectFolders: true, canSelectMany: true, defaultUri: dialogsService.defaultFolderPath(Schemas.file) - }).then(folders => { + }).then((folders): Promise | null => { if (!folders || !folders.length) { return null; } @@ -93,20 +93,13 @@ CommandsRegistry.registerCommand(PICK_WORKSPACE_FOLDER_COMMAND_ID, function (acc const folderPicks = folders.map(folder => { return { label: folder.name, - description: labelService.getUriLabel(resources.dirname(folder.uri), { relative: true }), + description: labelService.getUriLabel(resources.dirname(folder.uri)!, { relative: true }), folder, iconClasses: getIconClasses(modelService, modeService, folder.uri, FileKind.ROOT_FOLDER) } as IQuickPickItem; }); - let options: IPickOptions; - if (args) { - options = args[0]; - } - - if (!options) { - options = Object.create(null); - } + const options: IPickOptions = (args ? args[0] : undefined) || Object.create(null); if (!options.activeItem) { options.activeItem = folderPicks[0]; @@ -120,14 +113,7 @@ CommandsRegistry.registerCommand(PICK_WORKSPACE_FOLDER_COMMAND_ID, function (acc options.matchOnDescription = true; } - let token: CancellationToken; - if (args) { - token = args[1]; - } - - if (!token) { - token = CancellationToken.None; - } + const token: CancellationToken = (args ? args[1] : undefined) || CancellationToken.None; return quickInputService.pick(folderPicks, options, token).then(pick => { if (!pick) {